Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node API: improved structure, make MapModel public #6164

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Node API: improved structure, make MapModel public #6164

wants to merge 6 commits into from

Conversation

FloVanGH
Copy link
Member

  • Move TypeScript files in separate folder
  • Move model type to models.ts
  • Move MapModel out of private_api

tronical
tronical reviewed Sep 16, 2024
View reviewed changes
api/node/index.js.map Outdated Show resolved Hide resolved
api/node/__test__/js_value_conversion.spec.mts Show resolved Hide resolved
@tronical
Copy link
Member

(the file re-org looks okay to me)

tronical
tronical reviewed Sep 18, 2024
View reviewed changes
Copy link
Member

@tronical tronical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The model fix looks good!

There's one case where this doesn't work, which is when a rust created model is passed to MapModel, but these are read-only (in size as well as row data).

Please see comments inline and consider moving the Node.js specific test out of the global test cases directory and into the Node.js specific tests. Or is there something I overlooked that's only available in test-driver-nodejs but not accessible from index.ts?

api/node/typescript/models.ts Outdated Show resolved Hide resolved
api/node/typescript/models.ts Show resolved Hide resolved
tests/cases/models/map_model.slint Outdated Show resolved Hide resolved
tronical
tronical reviewed Sep 18, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tronical tronical tronical approved these changes

@ogoffart ogoffart ogoffart left review comments

@NigelBreslaw NigelBreslaw Awaiting requested review from NigelBreslaw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FloVanGH @tronical @ogoffart