Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add docker option to static hosting page #1648

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

jakobkordez
Copy link
Contributor

Adds a better and clearer guide to hosting static slides in a Docker container than is described in https://sli.dev/guide/install#install-on-docker

Copy link

netlify bot commented Jun 3, 2024

Deploy Preview for slidev ready!

Name Link
🔨 Latest commit 99d5d9e
🔍 Latest deploy log https://app.netlify.com/sites/slidev/deploys/6670524468fc8c00083a9d15
😎 Deploy Preview https://deploy-preview-1648--slidev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@KermanX
Copy link
Member

KermanX commented Jun 3, 2024

Thanks for your contribution!

I know almost nothing about Docker. Could you please also have a look at https://github.com/slidevjs/container? It seems to have lots of bugs.

And could we remove https://sli.dev/guide/install#install-on-docker as it's replaced by this one?

@jakobkordez
Copy link
Contributor Author

What would the purpose of slidevjs/container be?
Currently slidevjs/container is a bad solution for statically hosting slides, it runs with a node image and never runs slidev build, which means it will never actually build a static website but will run a development server with node.
My commit uses a node image to run slidev build then copies only the dist folder to an apache image for hosting the static

My commit only replaces https://sli.dev/guide/install#build-hostable-spa-single-page-application so maybe remove only that?

@KermanX
Copy link
Member

KermanX commented Jun 4, 2024

What would the purpose of slidevjs/container be?
Currently slidevjs/container is a bad solution for statically hosting slides, it runs with a node image and never runs slidev build, which means it will never actually build a static website but will run a development server with node.

The slidevjs/container runs a dev server because the built version doesn't support navigation sync.(#1227)

After #1227 is done, I think there can have a standalone navigation sync server as a Docker image.

My commit only replaces https://sli.dev/guide/install#build-hostable-spa-single-page-application so maybe remove only that?

Yes I think. This existing one seems not quite useful.

@KermanX
Copy link
Member

KermanX commented Jun 13, 2024

There seem to be so many ways to deploy Slidev via docker. AKAIK, there are:

IMO, after #1227 is done, the first two can be replaced by the standalone navigation sync server. The third one seems useless and out of Slidev's scope.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants