-
-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/docker #236
base: develop
Are you sure you want to change the base?
Feature/docker #236
Conversation
Disable IP Check on install automatically fill out server_path
I have issues running on wsl too, to solve this, I clone and up the containers inside wsl. On docker using hyper-v or Linux OS, works very well. Then the problem isnt the compose volume, is the files on Windows and volume on wsl |
Ok I get. But did you try running my docker files from this branch? |
Yes, running inside WSL, with compose volume, but i remove composer commands from Dockerfile and run inside container. |
Do you mean, you are running with this volumes defined? Which I commented out in latest commits? 72d7ee8#diff-e45e45baeda1c1e73482975a664062aa56f20c03dd9d64a827aba57775bed0d3L16 And it is no slow? Or you are running just this PR branch with latest changes, and it is no slow? Because I'm confused now. :P |
@@ -0,0 +1,53 @@ | |||
FROM php:8.2-apache |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would recommend using multi-stage build to avoid building all of this each time and why not nginx?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see any advantages of using nginx on single host for development purposes (this docker image is not intended for production).
About multi-stage build: thanks, didn't knew about that one. Will dive into it, and will see what can be done.
Is it even working anymore ? Whenever i try to reach MyAcc it gives me this error. |
This setup is extremally slow, takes more than 2 seconds per request, even with status disabled.The reason for this is currently not known for me.Edit: I found the reason and fixed it. That was because I was mounting volume directly through WSL 2, which is very slow.
Now it loads blazing fast.
How to build:
First clone this repo, and change branch to feature/docker (this PR)
It may take few minutes to download everything and build.
After this you will have 3 containers:
TFS schema will be automatically imported by docker init script.
in the 4) step - configuration set server path as follows:
/home/www-data/forgottenserver