Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(client): fallback to a hardcoded relay #55

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Nuhvi
Copy link
Contributor

@Nuhvi Nuhvi commented May 12, 2024

Add an option to use a hardcoded relay, this should allow Bitkit to not log relays in query params, and just focus on our server, which will make migration from "web relays" easier in the future after going out of beta.

@Nuhvi Nuhvi requested a review from dzdidi May 12, 2024 08:36
@dzdidi
Copy link
Contributor

dzdidi commented May 13, 2024

Isn't opts.relay serving this purpose already?

@Nuhvi
Copy link
Contributor Author

Nuhvi commented May 13, 2024

@dzdidi No, because that gets included in the URL when you call url() https://github.com/slashtags/web-relay/blob/main/lib/client/index.js#L76

@dzdidi
Copy link
Contributor

dzdidi commented May 13, 2024

I see, how about calling it defaultRelay (without _ prefix)? In my understanding used for internal things but this one is passed in options. Same applies for already implemented _skipCache, so IMO removing prefix there will make it better

@Nuhvi
Copy link
Contributor Author

Nuhvi commented May 13, 2024

It is prefixed because I don't want anyone already using the library (if any) to worry about it. The whole thing will be deprecated soon anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants