Firewall types and cross-stack subnet stuff#1509
Merged
Conversation
JackDoan
force-pushed
the
firewall-types
branch
2 times, most recently
from
0a95deb to
f09b99a
Compare
wadey
previously approved these changes
Nov 10, 2025
JackDoan
force-pushed
the
firewall-types
branch
from
5100718 to
7d874de
Compare
nbrownus
reviewed
Nov 12, 2025
nbrownus
reviewed
Nov 12, 2025
nbrownus
reviewed
Nov 12, 2025
…twork, is a VPN peer without an overlapping network, or is a unsafe network
* experiment with not filtering out non-common addresses in hostinfo.networks * allow handshakes without overlaps * checkpt * wow * lint * these comments were backwards and bamboozled me * lint * unsafe network test * unsafe network test reply * change HostInfo.buildNetworks argument to reference the cert
JackDoan
force-pushed
the
firewall-types
branch
from
7d874de to
4cff5e7
Compare
nbrownus
reviewed
Nov 12, 2025
nbrownus
approved these changes
Nov 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
firewall can distinguish if the host connecting has an overlapping network, is a VPN peer without an overlapping network, or is a unsafe network
has elements of #1498, but not the behavioral changes