Allow defining a route table id where routes will be installed#1503
Open
dioss-Machiel wants to merge 1 commit intoslackhq:masterfrom
Open
Allow defining a route table id where routes will be installed#1503dioss-Machiel wants to merge 1 commit intoslackhq:masterfrom
dioss-Machiel wants to merge 1 commit intoslackhq:masterfrom
Conversation
Collaborator
|
@dioss-Machiel Thanks for the PR! I like that this resolves some silly race conditions at startup. We will need to support pre v4.4 linux kernels though, sadly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This feature allows defining the route table id where Nebula will install routes to unlock the full potential of policy routing.
Additionally this also makes it so that the 'default routes' are always installed with the correct MTU, previously there was a tiny window where the MTU was not set.
This uses the IFA_F_NOPREFIXROUTE flag when setting the IP of the interface to avoid adding a route by default.
This flag was added in Linux kernel 4.4, if support for older kernel versions is required then more changes are going to be required.