Add task notes first attempt #72
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colmdoyle
reviewed
Jul 21, 2021
| @@ -24,6 +24,8 @@ module.exports = (sequelize, DataTypes) => { | |||
| }, | |||
| dueDate: DataTypes.DATE, | |||
| scheduledMessageId: DataTypes.STRING, | |||
| // Unsure if this is necessary | |||
There was a problem hiding this comment.
You definitely need this
| Blocks.Input({ label: 'Notes', blockId: 'taskNotes', optional: true }).element( | ||
| Elements.TextInput({ | ||
| actionId: 'taskNotes', | ||
| maxLength: 300, |
There was a problem hiding this comment.
Did you pick 300 at random or was their a specific reason for it?
| const option = { | ||
| text: `*${task.title}*`, | ||
| value: `open-task-${task.id}`, | ||
| }; | ||
| if (task.dueDate) { | ||
| option.description = `Due ${DateTime.fromJSDate(task.dueDate).toRelativeCalendar()}`; | ||
| option.description = `:spiral_calendar_pad:Due ${DateTime.fromJSDate(task.dueDate).toRelativeCalendar()}`; |
There was a problem hiding this comment.
is :spiral_calendar_pad: part of the standard emoji set? e.g. does it render on all workspaces?
There was a problem hiding this comment.
Suggested change
| option.description = `:spiral_calendar_pad:Due ${DateTime.fromJSDate(task.dueDate).toRelativeCalendar()}`; | |
| option.description = `:spiral_calendar_pad: Due ${DateTime.fromJSDate(task.dueDate).toRelativeCalendar()}`; |
| } | ||
| // Tried adding this line with some hardcoded text for each element but that didn't work either. | ||
| // I don't think TextInput can be passed in .elements but if that's the case documentation does not show how add mrkdwn elements to a Context block? | ||
| // Context().elements([Elements.TextInput({text:`something`})],[Elements.TextInput({text:`something else`})]) |
There was a problem hiding this comment.
There's two things here, which maybe because you haven't fully written out your thoughts, but as written
- There's nothing happening with the
Context(). You're not assigning it to anything, or trying to embed it into anything. It's like a fragment of a sentence in the middle of a story. - I don't think you can use a
Contextblock as an option inside an input block. You'd need to have it after the input block, which will make the list render funny.
There was a problem hiding this comment.
Here's the relevant docs on our side - https://api.slack.com/reference/block-kit/composition-objects#option
There was a problem hiding this comment.
Ok, I did some digging in the BlockBuilder source code and I think I have it.
Context({}).elements(['Foo', 'Bar']),
Comment on lines
+37
to
+55
| // LEAVING THIS UNTOUCHED FOR NOW | ||
|
|
||
| // for (start, end; start < end; start += maxOptionsLength) { | ||
| // holdingArray = openTasks.slice(start, start + maxOptionsLength); | ||
| // tasksInputsArray.push( | ||
| // Input({ label: ' ', blockId: `open-task-status-change-${start}` }).dispatchAction().element(Elements.Checkboxes({ actionId: 'blockOpenTaskCheckboxClicked' }).options(holdingArray.map((task) => { | ||
| // const option = { | ||
| // text: `*${task.title}*`, | ||
| // value: `open-task-${task.id}`, | ||
| // }; | ||
| // if (task.dueDate) { | ||
| // option.description = `Due ${DateTime.fromJSDate(task.dueDate).toRelativeCalendar()}`; | ||
| // } | ||
| // return Bits.Option(option); | ||
| // }))), | ||
| // ); | ||
| // } | ||
|
|
||
| // SANDRA TESTING |
There was a problem hiding this comment.
I'm assuming this is just the old code, so not looking at it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Describe the goal of this PR. Mention any related Issue numbers.
Requirements (place an
xin each[ ])