refactor: switch to Rust #131

kyranet · 2022-05-11T01:10:54Z

~~Pending to fix tests and write tests for Rust's side of things~~

Nytelife26 · 2022-05-11T16:50:12Z

Bindings tests need to be fixed to include Rust. They're failing because Cargo isn't present.

Nytelife26

No further comments for now. Good work :)
I'll check more in-depth later.

.gitignore

npm/linux-x64-musl/package.json

src/games/connect_four.rs

src/games/tic_tac_toe.rs

src/common/mod.rs

Nytelife26

After this and the macro for tidying up, I'll move to performance analysis. If you'd like to do some of your own in the meantime at the machine code level, I'd recommend using Godbolt.

src/lib.rs

src/games/tic_tac_toe.rs

src/games/connect_four.rs

.github/workflows/continuous-integration.yml

favna

That'll be enough to go on with for now.

.github/workflows/continuous-integration.yml

Nytelife26 · 2022-05-11T23:39:15Z

Since Player implements PartialEq, you can replace the redundant compare functions in each game module with this more idiomatic solution that can be stored in src/lib.rs.

This will also work for any other type that implements PartialEq, and is variadic.

macro_rules! many_eq {
    ($x:expr, $y:expr $(,$rest:expr)*) => {
        $x == $y && many_eq!($y $(,$rest)*)
    };
    ($x:expr) => { true };
}

Nytelife26

I equally dislike myself for not mentioning this sooner. Although, fortunately, it's probably the easiest change I've pointed out.

index.d.ts

.github/workflows/continuous-integration.yml

package.json

src/games/connect_four.rs

src/games/tic_tac_toe.rs

src/games/connect_four.rs

Nytelife26

LGTM after that final nitpick.

favna

Barring this I have no idea about the production code but I trust Nyte reviewed that. I also have no idea how to version and publish it so that will be on your shoulders.

.github/workflows/continuous-integration.yml

favna · 2022-06-01T21:18:16Z

.github/workflows/continuous-integration.yml

+          node-version: 16
+          check-latest: true
+          cache: yarn
+          architecture: ${{ matrix.settings.architecture }}


Resolved without reply

favna · 2022-06-01T21:19:07Z

.github/workflows/continuous-integration.yml

+    strategy:
+      fail-fast: false
+      matrix:
+        settings:


Resolved without resolution. This still applies.

.gitignore

package.json

favna · 2022-06-01T21:28:50Z

package.json

+		"build:debug": "napi build --platform --js index.cjs --pipe \"prettier -w\"",
+		"update": "yarn upgrade-interactive",
+		"prepublishOnly": "napi prepublish -t npm",
+		"prepare": "husky install .github/husky",


Suggested change

"prepare": "husky install .github/husky",

"postinstall": "husky install .github/husky",

"postpack": "pinst --enable"

package.json

Nytelife26 · 2022-09-08T02:03:52Z

Status on this?

kyranet · 2022-09-08T03:19:02Z

There are TODOs left to do before merging, and I'm sadly too busy for that at the moment :/

Nytelife26 · 2022-09-08T15:05:03Z

There are TODOs left to do before merging, and I'm sadly too busy for that at the moment :/

If there's anything you want me to do, let me know. I'm moving into student accommodation soon so I'll be mostly free until the 23rd.

Co-Authored-By: Tyler J Russell <[email protected]>

kyranet added Meta: Refactor labels May 11, 2022

kyranet requested a review from favna May 11, 2022 01:10

Nytelife26 requested changes May 11, 2022

View reviewed changes

Nytelife26 reviewed May 11, 2022

View reviewed changes

src/lib.rs Show resolved Hide resolved

src/lib.rs Outdated Show resolved Hide resolved

src/games/tic_tac_toe.rs Outdated Show resolved Hide resolved

src/games/connect_four.rs Outdated Show resolved Hide resolved

favna requested changes May 11, 2022

View reviewed changes

.github/workflows/continuous-integration.yml Outdated Show resolved Hide resolved

favna requested changes May 11, 2022

View reviewed changes

kyranet force-pushed the refactor/rusty branch 3 times, most recently from 728db83 to e328b6c Compare May 15, 2022 23:49

Nytelife26 reviewed May 16, 2022

View reviewed changes

index.d.ts Outdated Show resolved Hide resolved

kyranet marked this pull request as ready for review May 16, 2022 17:51

kyranet requested a review from favna May 16, 2022 17:52

Nytelife26 reviewed May 17, 2022

View reviewed changes

src/games/connect_four.rs Outdated Show resolved Hide resolved

Nytelife26 approved these changes May 17, 2022

View reviewed changes

favna requested changes Jun 1, 2022

View reviewed changes

kyranet force-pushed the refactor/rusty branch from d070552 to 90e212a Compare June 1, 2022 21:37

github-actions bot removed Meta: Refactor labels Jul 25, 2022

kyranet force-pushed the refactor/rusty branch 5 times, most recently from 3b23a2d to d633a06 Compare July 14, 2023 15:50

kyranet force-pushed the refactor/rusty branch 3 times, most recently from 8ad2726 to 7ccb5c8 Compare July 21, 2023 14:58

kyranet and others added 3 commits April 16, 2024 10:00

refactor: switch to Rust

92f5152

Co-Authored-By: Tyler J Russell <[email protected]>

refactor: resync template

05821b8

chore: add missing tests (#218)

3d28ca4

kyranet force-pushed the refactor/rusty branch from 555d778 to 3d28ca4 Compare April 16, 2024 08:01

kyranet added 9 commits April 16, 2024 10:11

chore: resync template

e6a2831

fix: resolved CI errors

9d60186

fix: sync lockfile

aa6833d

chore: update template once again

635b5d5

chore: explictly install eslint

21ed7d4

fix: resolve clippy issues

c192830

fix: bad copypasta

fd6e7c4

ci: remove i686

496e469

ci: install nightly toolchain for cargo fmt

d174feb

kyranet merged commit 7260e2c into main Apr 16, 2024
28 checks passed

kyranet deleted the refactor/rusty branch April 16, 2024 09:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: switch to Rust #131

refactor: switch to Rust #131

kyranet commented May 11, 2022 •

edited

Loading

Nytelife26 commented May 11, 2022

Nytelife26 left a comment

Nytelife26 left a comment

favna left a comment

Nytelife26 commented May 11, 2022 •

edited

Loading

Nytelife26 left a comment

Nytelife26 left a comment

favna left a comment

favna Jun 1, 2022

favna Jun 1, 2022

favna Jun 1, 2022

Nytelife26 commented Sep 8, 2022

kyranet commented Sep 8, 2022

Nytelife26 commented Sep 8, 2022

	"prepare": "husky install .github/husky",
	"postinstall": "husky install .github/husky",
	"postpack": "pinst --enable"

refactor: switch to Rust #131

refactor: switch to Rust #131

Conversation

kyranet commented May 11, 2022 • edited Loading

Nytelife26 commented May 11, 2022

Nytelife26 left a comment

Choose a reason for hiding this comment

Nytelife26 left a comment

Choose a reason for hiding this comment

favna left a comment

Choose a reason for hiding this comment

Nytelife26 commented May 11, 2022 • edited Loading

Nytelife26 left a comment

Choose a reason for hiding this comment

Nytelife26 left a comment

Choose a reason for hiding this comment

favna left a comment

Choose a reason for hiding this comment

favna Jun 1, 2022

Choose a reason for hiding this comment

favna Jun 1, 2022

Choose a reason for hiding this comment

favna Jun 1, 2022

Choose a reason for hiding this comment

Nytelife26 commented Sep 8, 2022

kyranet commented Sep 8, 2022

Nytelife26 commented Sep 8, 2022

kyranet commented May 11, 2022 •

edited

Loading

Nytelife26 commented May 11, 2022 •

edited

Loading