[jobs] make status updates robust when controller dies #4602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This discrepancy caused issues, such as jobs getting stuck as CANCELLING when the job controller process crashes during cleanup.
|
/quicktest-core |
|
/quicktest-core |
Michaelvll
reviewed
Jan 22, 2025
Michaelvll
approved these changes
Jan 23, 2025
| 'Waiting for controller process to be RUNNING') + '{status_str}' | ||
| status_display = rich_utils.safe_status(status_msg.format(status_str='')) | ||
|
|
||
| def should_keep_logging(status: managed_job_state.ManagedJobStatus) -> bool: |
There was a problem hiding this comment.
minor: Should we allow this function to take Optional[managed_job_state.ManagedJobStatus, so that we don't have to assert before every invocation of this function?
There was a problem hiding this comment.
I don't really like any of the alternatives:
- Function accepts
Optional[managed_job_state.ManagedJobStatus]but throws if it gets None - feels like the type is just wrong in that case. - Function accepts
Optional[managed_job_state.ManagedJobStatus]and returns True (or maybe False?) if it gets None - feels inaccurate. - Wrap
get_latest_task_id_statusto assert non-None status - feels overengineered. - Change all the status-fetching functions to throw if the job does not exist - maybe correct, but out of scope for this PR.
So I guess I'd prefer to just keep this - it's a bit verbose but it's pretty simple and understandable.
Co-authored-by: Zhanghao Wu <[email protected]>
|
/quicktest-core |
|
/smoke-test managed_jobs |
|
smoke test failure is unrelated, should be fixed in #4548 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In combination with #4552 and #4562, the internal state machine for job status and schedule state should be much more robust and likely to eventually get to a consistent state, even under high load.
Tested (run the relevant ones):
bash format.shpytest tests/test_smoke.pypytest tests/test_smoke.py::test_fill_in_the_nameconda deactivate; bash -i tests/backward_compatibility_tests.sh