-
Notifications
You must be signed in to change notification settings - Fork 555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs] Multiple k8s support #4586
base: master
Are you sure you want to change the base?
Conversation
Added the figure. Ready for review @romilbhardwaj. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Michaelvll! This is great, left some comments.
|
||
In this example, we have two Kubernetes clusters: ``my-h100-cluster`` and ``my-tpu-cluster``, and each Kubernetes cluster has a context for it. | ||
|
||
Point to a Kubernetes Cluster and Launch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to have a section on adding contexts to allowed_contexts". If allowed_contexts
is not set, I believe --region
will not work, we will only use the active context.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be good to clearly mark section titles:
Step 1 - Set Up Credentials for Multiple Kubernetes Clusters
Step 2 - Configure SkyPilot to access multiple clusters
Then have sections on launching, show-gpus, failover etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As the final check, we have the users run sky check kubernetes
as a way to verify which contexts are available to SkyPilot.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point! Updated the doc. PTAL.
Co-authored-by: Romil Bhardwaj <[email protected]>
Co-authored-by: Romil Bhardwaj <[email protected]>
…into multi-k8s-docs-v2
@@ -245,10 +245,10 @@ def _format_enabled_cloud(cloud_name: str) -> str: | |||
# here we are using rich. We should migrate this file to | |||
# use colorama as we do in the rest of the codebase. | |||
symbol = ('└── ' if i == len(existing_contexts) - 1 else '├── ') | |||
contexts_formatted.append(f'\n {symbol}{context}') | |||
contexts_formatted.append(f'\n {symbol}{context}') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reduced the indent for cleaner view, cc'ing @romilbhardwaj : )
Tested (run the relevant ones):
bash format.sh
pytest tests/test_smoke.py
pytest tests/test_smoke.py::test_fill_in_the_name
conda deactivate; bash -i tests/backward_compatibility_tests.sh