Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Nebius Cloud #4573

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

SalikovAlex
Copy link

@SalikovAlex SalikovAlex commented Jan 16, 2025

Add support Nebius Cloud

Tested (run the relevant ones):

  • Code formatting: bash format.sh
  • Any manual or new tests for this PR (please specify below)
  • All smoke tests: pytest tests/test_smoke.py
  • Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
  • Backward compatibility tests: conda deactivate; bash -i tests/backward_compatibility_tests.sh

Copy link
Collaborator

@cblmemo cblmemo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @SalikovAlex for this amazing work! I think the PR is in a good shape. Left some nits. In the same time, could you help test the basic functionality of this new cloud? include but not limited to:

  • Launch CPU only instance
  • Launch GPU instance
  • Stop & Re-launch, check if the disk is persistent (write some content before stop, and cat them after re-launch)
  • Autostop & Autodown
  • Launch on existing cluster
  • SSH to the cluster
  • Failover: make sure it can failover from lambda to other clouds and the exceptions are printed correctly
  • launch on other clouds without nebius dependencies installed (make sure it does not introduce unnecessary dependencies when vast is not enabled)

examples/minimal.yaml Outdated Show resolved Hide resolved
sky/authentication.py Outdated Show resolved Hide resolved
sky/clouds/nebius.py Outdated Show resolved Hide resolved
sky/clouds/nebius.py Outdated Show resolved Hide resolved
sky/clouds/nebius.py Outdated Show resolved Hide resolved
sky/provision/nebius/utils.py Outdated Show resolved Hide resolved
sky/setup_files/MANIFEST.in Outdated Show resolved Hide resolved
@@ -139,6 +139,7 @@
# docs instead.
# 'vsphere-automation-sdk @ git+https://github.com/vmware/[email protected]' pylint: disable=line-too-long
],
'nebius': ['nebius @ git+https://github.com/nebius/pysdk@876bb16']
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason to not use a stable release?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will fix it as soon as Nebius publishes lib on PiPy.


provider:
type: external
module: sky.skylet.providers.nebius.NebiusNodeProvider
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
module: sky.skylet.providers.nebius.NebiusNodeProvider
module: sky.provision.nebius

i think this should be the provision module? as we are using the new provisioner here

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: eol

@cblmemo
Copy link
Collaborator

cblmemo commented Jan 22, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants