-
Notifications
You must be signed in to change notification settings - Fork 549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Nebius Cloud #4573
base: master
Are you sure you want to change the base?
Add Nebius Cloud #4573
Conversation
Add Nebius Cloud
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @SalikovAlex for this amazing work! I think the PR is in a good shape. Left some nits. In the same time, could you help test the basic functionality of this new cloud? include but not limited to:
- Launch CPU only instance
- Launch GPU instance
- Stop & Re-launch, check if the disk is persistent (write some content before stop, and cat them after re-launch)
- Autostop & Autodown
- Launch on existing cluster
- SSH to the cluster
- Failover: make sure it can failover from lambda to other clouds and the exceptions are printed correctly
- launch on other clouds without nebius dependencies installed (make sure it does not introduce unnecessary dependencies when vast is not enabled)
@@ -139,6 +139,7 @@ | |||
# docs instead. | |||
# 'vsphere-automation-sdk @ git+https://github.com/vmware/[email protected]' pylint: disable=line-too-long | |||
], | |||
'nebius': ['nebius @ git+https://github.com/nebius/pysdk@876bb16'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any reason to not use a stable release?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will fix it as soon as Nebius publishes lib on PiPy.
|
||
provider: | ||
type: external | ||
module: sky.skylet.providers.nebius.NebiusNodeProvider |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
module: sky.skylet.providers.nebius.NebiusNodeProvider | |
module: sky.provision.nebius |
i think this should be the provision module? as we are using the new provisioner here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: eol
Add support Nebius Cloud
Tested (run the relevant ones):
bash format.sh
pytest tests/test_smoke.py
pytest tests/test_smoke.py::test_fill_in_the_name
conda deactivate; bash -i tests/backward_compatibility_tests.sh