This repository has been archived by the owner on Oct 19, 2018. It is now read-only.
Add option to do a native read/write of half float data packed as uint16 matrices #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nexr development packages installed in system default directories and tested on Ubuntu 18.04
… is stored as uint16 with correct IEEE 754-2008 half float bit layout. Also offering a wrapper function (exrwritehalf) to allow easy access of half float writer to allow easy use.
…red with a helper function to read all channels as packed half data and resort channels to correct order.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extends exrreadchannels and exrwritechannels to allow passing half float data packed into uint16 matrices. It is implemented to keep it as simple as possible while not changing to much of the original code.
If this is of interest but you don't like the way it is implemented I'm open for suggestions. This was the first time I worked on mex extensions myself and I'm sure there might be a better way for some things. (I especially don't like the way the read as uint16 is passed in exrreadchannels but as all string style parameters after the filename are expected to be channel names I thought this is the easiest way.)
To simplify use of those functions I added two wrapper functions (exrreadhalf and exrwritehalf) which set a default set of parameters.
Additionally I did a small change in the make.m file assuming running on default folder structure like the one on Debian/Ubuntu.