Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove python 3.8 and add tfx 1.15 build in kfp compiler #388

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Remove python 3.8 and add tfx 1.15 build in kfp compiler #388

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions argo/kfp-compiler/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,3 @@
FROM python:3.8.18 AS PYTHON38
ARG WHEEL_VERSION

COPY dist/*-${WHEEL_VERSION}-*.whl /
RUN pip install /*-${WHEEL_VERSION}-*.whl --target=/kfp-compiler && \
rm /*-${WHEEL_VERSION}-*.whl

FROM python:3.9.13 AS PYTHON39
ARG WHEEL_VERSION

Expand All @@ -22,7 +15,6 @@ RUN pip install /*-${WHEEL_VERSION}-*.whl --target=/kfp-compiler && \
FROM alpine:3.20.1

WORKDIR /
COPY --from=PYTHON38 /kfp-compiler kfp-compiler/py3.8
COPY --from=PYTHON39 /kfp-compiler kfp-compiler/py3.9
COPY --from=PYTHON310 /kfp-compiler kfp-compiler/py3.10
ADD resources/compile.sh kfp-compiler/compile.sh
Expand Down
10 changes: 5 additions & 5 deletions argo/kfp-compiler/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,23 +13,23 @@ penguin-staging:
cp ../../docs-gen/includes/quickstart/penguin_pipeline/*.py $(PENGUIN_STAGING)
cp integration/Dockerfile $(PENGUIN_STAGING)

penguin-38: penguin-staging
docker build --build-arg PYTHON_VERSION=3.8.17 --build-arg TFX_VERSION=1.9.1 -t penguin:3.8 $(PENGUIN_STAGING)

penguin-39: penguin-staging
docker build --build-arg PYTHON_VERSION=3.9.13 --build-arg TFX_VERSION=1.9.1 -t penguin:3.9 $(PENGUIN_STAGING)

penguin-310: penguin-staging
docker build --build-arg PYTHON_VERSION=3.10.12 --build-arg TFX_VERSION=1.14.0 -t penguin:3.10 $(PENGUIN_STAGING)

integration-test: docker-build penguin-38 penguin-39 penguin-310
penguin-310-115: penguin-staging
docker build --build-arg PYTHON_VERSION=3.10.12 --build-arg TFX_VERSION=1.15.0 -t penguin:3.10-1.15 $(PENGUIN_STAGING)

integration-test: docker-build penguin-39 penguin-310 penguin-310-115
$(eval TMP := $(shell mktemp -d))
echo '{"rootLocation": "pipeline_root", "servingLocation": "serving", "name": "test", "image": "test-pipeline", "tfxComponents": "pipeline.create_components"}' > $(TMP)/pipeline_config.json
docker run -v $(TMP):/shared kfp-operator-argo-kfp-compiler /shared
docker run -v $(TMP):/shared --entrypoint /shared/compile.sh penguin:3.10 --output_file /tmp/pipeline.yaml --pipeline_config /shared/pipeline_config.json --execution_mode v1
docker run -v $(TMP):/shared --entrypoint /shared/compile.sh penguin:3.8 --output_file /tmp/pipeline.yaml --pipeline_config /shared/pipeline_config.json --execution_mode v2
docker run -v $(TMP):/shared --entrypoint /shared/compile.sh penguin:3.9 --output_file /tmp/pipeline.yaml --pipeline_config /shared/pipeline_config.json --execution_mode v2
docker run -v $(TMP):/shared --entrypoint /shared/compile.sh penguin:3.10 --output_file /tmp/pipeline.yaml --pipeline_config /shared/pipeline_config.json --execution_mode v2
docker run -v $(TMP):/shared --entrypoint /shared/compile.sh penguin:3.10-1.15 --output_file /tmp/pipeline.yaml --pipeline_config /shared/pipeline_config.json --execution_mode v2

##@ Build

Expand Down