Skip to content

Commit

Permalink
docs: add migration notice for ASP.NET Core integration and move chan…
Browse files Browse the repository at this point in the history
…gelog to GitHub releases.
  • Loading branch information
skwasjer committed Sep 2, 2023
1 parent d2fd29a commit 3e3be5c
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 9 deletions.
1 change: 0 additions & 1 deletion Correlate.sln
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Solution Items", "Solution
.editorconfig = .editorconfig
.gitignore = .gitignore
appveyor.yml = appveyor.yml
CHANGELOG.md = CHANGELOG.md
Directory.Build.props = Directory.Build.props
README.md = README.md
EndProjectSection
Expand Down
11 changes: 3 additions & 8 deletions CHANGELOG.md → OLD_CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,13 +1,8 @@
# Changelog

## Unreleased

- Added .NET 7 target framework
- Refactored ASP.NET Core integration to be based on `DiagnosticsListener`, by subscribing an observer and watch for HttpRequestIn (activity) events. This gives us the soonest opportunity to create the correlation context. Previously, `.UseCorrelate()` would register middleware. There were a few downsides with that approach, all having to do with _when_ the correlation context actually was being created:
- it was depending on the registration order when considering other middleware. F.ex. if `UseCorrelate()` was not called before any other middleware was registered, the correlation context was also not created as soon as possible.
- the ASP.NET Core its own built-in request-start and request-stop log messages did not have a Correlation ID property attached because the log scope created by Correlate is created after/disposed before these are emitted.
- for unhandled exceptions, the correlation context was already gone in the global exception handler because the request middleware pipeline completes before it gets there (unless you registered a custom one!). Again, this means those (default) log messages would not have a correlation ID property (see previous point).
- the middleware had a little too many allocations to my liking (considering that it runs in a fast-path).
## Future changelog moved to GitHub releases
From v5.0.0 onwards, the changelog can be found at:
https://github.com/skwasjer/Correlate/releases

## v4.0.0

Expand Down
4 changes: 4 additions & 0 deletions src/Correlate.AspNetCore/README.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
Provides abstractions to correlate requests between microservices.

### Migration from v4.x to 5.0.0

- Replace `Correlate.AspNetCore.Middleware` namespace with `Correlate.AspNetCore`.

### Useful links

- [GitHub / docs](https://github.com/skwasjer/Correlate)
Expand Down

0 comments on commit 3e3be5c

Please sign in to comment.