Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed RuntimeError on variable validation batch size #1511

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Luke-Chesley
Copy link

Description

Changed dimension in concat_sequences to cat along dim = 0. This fixes bug mentioned in linked issue.

Checklist

  • Linked issues (if existing)
  • Amended changelog for large changes (and added myself there as contributor)
  • Added/modified tests
  • Used pre-commit hooks when committing to ensure that code is compliant with hooks. Install hooks with pre-commit install.
    To run hooks independent of commit, execute pre-commit run --all-files

@codecov-commenter
Copy link

codecov-commenter commented Feb 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b3fcf86) 90.19% compared to head (67ed8e5) 90.11%.
Report is 8 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1511      +/-   ##
==========================================
- Coverage   90.19%   90.11%   -0.09%     
==========================================
  Files          30       30              
  Lines        4724     4724              
==========================================
- Hits         4261     4257       -4     
- Misses        463      467       +4     
Flag Coverage Δ
cpu 90.11% <100.00%> (-0.09%) ⬇️
pytest 90.11% <100.00%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Luke-Chesley and others added 2 commits February 11, 2024 09:54
	modified:   pytorch_forecasting/models/temporal_fusion_transformer/__init__.py
	modified:   tests/test_models/test_temporal_fusion_transformer.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants