Nhits weight argument fix in TimeSeriesDataSet #1432
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a weight argument to TimeSeriesDataSet will cause the trainer to throw an error for NhiTS because of a dimension mismatch in dimension 1.
This is because of unsqueeze operation and it is not solely because of missing values (the error will happen even when there is no missing values).
To fix this we can remove the unsqueeze(-1) and multiply the losses and weight directly.
(Ignore the first few commits as they are for NHitS encode-decoder length which is already merged to main)
This is the commit: (**Remove Unsqueeze operation to solve the mismatch operation)
I confirm this by running the same NhiTS model with weight operation set:
Issues:
#1431
#1040