Add WSL compatibility impplementation. #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow integration with Android Studio at Windows platform when WSL (Windows Subsystem for Linux) is used By default the plugin doesn't work at Windows environment. WSL adds possibility to call linux commands using "bash" shell. The update allows mirakel to wrap ssh/rsync commands execution with the explicit "bash" shell usage.
|
Hey, big thanks for the help with the Windows support, I will review PR in a few days. |
|
It works on windows. The main question whether it breaks MacOS and Linux compatibility |
|
I will take care of testing it on macos and linux. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow integration with Android Studio at Windows platform when WSL (Windows Subsystem for Linux) is used
By default the plugin doesn't work at Windows environment. WSL adds possibility to call linux commands using "bash" shell. The update allows mirakle to wrap ssh/rsync commands execution with the explicit "bash" shell usage.