Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce connecting both wallets before previewing route #68

Merged
merged 8 commits into from
Nov 2, 2023

Conversation

thal0x
Copy link
Member

@thal0x thal0x commented Oct 31, 2023

Fixes issue where a user selects a route involving both an EVM and Cosmos chain, but only has one wallet connected, they are still able to open the transaction dialog. Now both wallets are required.

@thal0x thal0x self-assigned this Oct 31, 2023
@vercel
Copy link

vercel bot commented Oct 31, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ibc-dot-fun ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 31, 2023 1:27pm

Copy link
Contributor

@Zygimantass Zygimantass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

);
const {
address: destinationChainAddress,
isWalletConnected: isDestinationWalletconnected,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: isDestinationWalletConnected

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoops

@@ -73,6 +75,8 @@ const AssetSelectContent: FC<Props> = ({
return asset.denom.toLowerCase().includes(searchValue.toLowerCase());
});

console.log(filteredAssets);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wild console.log spotted

@thal0x thal0x merged commit d30a759 into update-symbol-naming Nov 2, 2023
4 checks passed
@thal0x thal0x deleted the enforce-both-wallets-connected branch November 2, 2023 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants