[ENG-1528] Use assets endpoint instead of chain registry #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
thal0x
commented
Jul 27, 2023
| @@ -0,0 +1,29 @@ | |||
| import { Asset, AssetWithMetadata } from "./types"; | |||
|
|
|||
| export function assetHasMetadata(asset: Asset) { | |||
There was a problem hiding this comment.
Currently the API returns a lot of assets that are not necessarily "assets", like osmosis pool tokens (see: https://api.skip.money/v1/fungible/assets?chain_id=osmosis-1&native_only=true).
Do we want this? (will post in slack)
Either way for now this seems to be the best way to filter them out of the UI.
thal0x
changed the title
bpiv400
approved these changes
Jul 27, 2023
[ENG-1513] Scroll relay warning into view when opened
Track amount and asset of successful txs
lifecycle tracking v0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.