Create Skip API client #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploy max fee button to prod
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
bpiv400
requested changes
Jul 27, 2023
src/solve/client/client.ts
Outdated
Comment on lines
8
to
13
| export const ENDPOINTS = { | ||
| GET_CHAINS: `${API_URL}/info/chains`, | ||
| GET_ROUTE: `${API_URL}/fungible/route`, | ||
| }; | ||
|
|
||
| export const IGNORE_CHAINS = ["agoric", "8ball", "akashnet-2"]; |
There was a problem hiding this comment.
Should these be passed into the client as arguments?
src/solve/client/client.ts
Outdated
| const API_URL = process.env.NEXT_PUBLIC_API_URL ?? "https://api.skip.money/v1"; | ||
|
|
||
| export const ENDPOINTS = { | ||
| GET_CHAINS: `${API_URL}/info/chains`, |
There was a problem hiding this comment.
Why are we only defining endpoints for these routes?
Shouldn't these be given by functions / vars on the client itself?
There was a problem hiding this comment.
yeah this was something i started to do and then abandoned, just removed it
[ENG-1513] Scroll relay warning into view when opened
Track amount and asset of successful txs
lifecycle tracking v0
[ENG-1528] Use assets endpoint instead of chain registry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first PR in a series of PRs to clean up code and add tests.
SkipClientthat provides methods for calling the Skip API.SkipClientthat modifies requests or responses.