Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Provide Configuration Options for POB #205

Closed
wants to merge 85 commits into from
Closed

feat: Provide Configuration Options for POB #205

wants to merge 85 commits into from

Conversation

keefertaylor
Copy link
Contributor

@keefertaylor keefertaylor commented Jul 11, 2023 •
edited
Loading

NOTE: This PR was originally proposed against main in #203. I am also merging it into our release/v1.x.x branch. I addressed reviewers comments in the other thread, and linked the commits here.

===

When integrating into Duality we discovered that not all chains will have a Distribution Module.

To account for this, add a new abstraction, RewardsAddressProvider that will instruct the moduled as to where auction rewards should go. There are two options provided:

  1. ProposerRewardsAddressProvider: Send rewards to the block proposer
  2. FixedAddressRewardsAddressProvider: Send rewards to the same address

Notes:

  • The default dependency injection strategy for the module will use the Proposer provider, chains can override this preference
  • There is boilerplate code to inject a Fixed provider. This will default to the module's address and chains can provide their own injection binding if they want something else.
  • I didn't see a unit test for auction profits, so I haven't added an additional test.

dependabot bot and others added 30 commits April 14, 2023 14:29
@dependabot @alexanderbez
chore(deps): bump goreleaser/goreleaser-action from 3 to 4 (#62)
64e1dd2 
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Aleksandr Bezobchuk <[email protected]>
@davidterpay @alexanderbez
[ENG-711]: First write through of the spec (#57)
bea9ead 
Co-authored-by: Aleksandr Bezobchuk <[email protected]>
Co-authored-by: Aleksandr Bezobchuk <[email protected]>
@alexanderbez
Rename spec.md to SPEC.md (#67)
1846e2b
@davidterpay
[ENG-731]: Support for Dependencies Injection (#65)
a831b25
@davidterpay
[ENG-733]: Supporting generic auction transaction configurations (#66)
46c4dcc
@dependabot @alexanderbez
chore(deps): bump cosmossdk.io/api from 0.3.1 to 0.4.0 (#75)
451e19f 
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Aleksandr Bezobchuk <[email protected]>
@dependabot @alexanderbez
chore(deps): bump github.com/cosmos/cosmos-proto from 1.0.0-beta.2 to…
d835a6e 
… 1.0.0-beta.3 (#73)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Aleksandr Bezobchuk <[email protected]>
@dependabot @alexanderbez
chore(deps): bump github.com/cosmos/gogoproto from 1.4.7 to 1.4.8 (#72)
654165e 
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Aleksandr Bezobchuk <[email protected]>
@dependabot
chore(deps): bump cosmossdk.io/core from 0.3.2 to 0.6.1 (#74)
f1bbace 
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@alexanderbez
ci: Create lint-pr.yml (#78)
fec01ac
@davidterpay @alexanderbez
fix(timeouts): [ENG-749] Making timeouts configurable (#79)
5231caf 
Co-authored-by: Aleksandr Bezobchuk <[email protected]>
@davidterpay
fix: [ENG-754] Refactor of Mempool Dep to Interfaces (#81)
e5be99b
@davidterpay
fix(config)!: Auction mempool inherits config interface (#82)
5f5a1c1
@dependabot
chore(deps): bump cosmossdk.io/api from 0.4.0 to 0.4.1 (#88)
d3a36f5 
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@davidterpay @alexanderbez
fix: Removing normal transactions using RemoveWithoutRefTx (#89)
328d28d 
Co-authored-by: Aleksandr Bezobchuk <[email protected]>
@davidterpay @alexanderbez
test: [ENG-758]: Tx config testing (#91)
57a6393 
Co-authored-by: Aleksandr Bezobchuk <[email protected]>
@alexanderbez
feat: prep POB with ABCI++ 2.0 Vote Ext Types (#94)
c377347
@dependabot
chore(deps): bump github.com/cometbft/cometbft from 0.37.0 to 0.37.1 (#…
ee0ab98 
…99)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@davidterpay
feat(v1): Init vote extension handlers (#95)
c8f0f1b
@dependabot @alexanderbez
chore(deps): bump github.com/cosmos/cosmos-sdk from 0.47.1 to 0.47.2 (#…
03f6f22 
…101)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Aleksandr Bezobchuk <[email protected]>
@davidterpay
fix: ABCI top bid bug (#102)
ab6385e
@dependabot
chore(deps): bump github.com/cosmos/gogoproto from 1.4.8 to 1.4.9 (#109)
6a9818a 
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@alexanderbez
chore: Create LICENSE (#110)
9fa8524
@alexanderbez
feat: add events to MsgAuctionBid handler (#111)
14827d5
@davidterpay @alexanderbez
feat(v1): [ENG-790] Implementing vote extension handlers (#103)
07c76b8 
Co-authored-by: Aleksandr Bezobchuk <[email protected]>
@davidterpay
fix(Config): Simplifying config interface (#104)
d58b36b
@davidterpay
fix(proto): File structure fix (#115)
32e2af0
@alexanderbez
docs: update spec (#90)
e35b396
@dependabot
chore(deps): bump google.golang.org/grpc from 1.54.0 to 1.55.0 (#118)
e913bee 
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@alexanderbez
feat: [ENG-792] Implement E2E Testing Framework (#107)
cc74b9e
davidterpay and others added 17 commits June 8, 2023 20:23
@davidterpay
feat(BB): Decoding Txs before ProcessLane + IgnoreList (#170)
3d505ed
@davidterpay
feat(BB): Better proposal, better docs, better logging, papa johns (#172
cee39a9 
)
@davidterpay
feat(bb): Multi-lane testing + docs (#174)
04f3862
@dependabot
chore(deps): bump google.golang.org/grpc from 1.55.0 to 1.56.1 (#177)
d588aa0 
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps): bump github.com/cometbft/cometbft from 0.37.1 to 0.37.2 (#…
07ec3f4 
…175)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps): bump google.golang.org/protobuf from 1.30.0 to 1.31.0 (#188
d884aee 
)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @davidterpay
chore(deps): bump github.com/cosmos/cosmos-sdk from 0.47.2 to 0.47.3 (#…
91af6a4 
…173)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: David Terpay <[email protected]>
Co-authored-by: David Terpay <[email protected]>
@davidterpay
fix(Audit): Audit issues (#190)
e873dfd
@keefertaylor
scope an interface
64022e1
@keefertaylor
Plumb rewards provider into the module
2675ade
@keefertaylor
Utilize the rewards address provider
cac5fb8
@keefertaylor
rip out direct dependencies on staking and distribution modules
2aff596
@keefertaylor
Create a new fixed rewards address rewarder
94ea2c3
@keefertaylor
Provide dependency injection for fixed address
2719eb3
@keefertaylor
slightly better function name
2222a21
@keefertaylor
fix linter errors
ab2f7ce
@keefertaylor
second attempt
9c29081
@keefertaylor keefertaylor changed the base branch from main to release/v1.x.x July 11, 2023 19:13
@keefertaylor keefertaylor mentioned this pull request Jul 11, 2023
Closed
@keefertaylor keefertaylor changed the title 2nd attempt at a 1.x.x merge feat: Provide Configuration Options for POB Jul 11, 2023
@keefertaylor
Copy link
Contributor Author

Closing in favor of #206 206

@keefertaylor keefertaylor deleted the keefer/1.x.x-addr-provider branch July 11, 2023 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@keefertaylor @davidterpay @alexanderbez