fix: nil pointer for gas_prices query #146
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freeelancer
requested review from
aljo242,
Eric-Warehime,
technicallyty and
wesl-ee
as code owners
|
@freeelancer thanks for opening this. Could we get a test against this newly added logic? |
tac0turtle
reviewed
Sep 23, 2024
| @@ -114,6 +114,10 @@ func (k *Keeper) GetMinGasPrices(ctx sdk.Context) (sdk.DecCoins, error) { | |||
| minGasPrice := sdk.NewDecCoinFromDec(params.FeeDenom, baseGasPrice) | |||
| minGasPrices := sdk.NewDecCoins(minGasPrice) | |||
|
|
|||
| if k.resolver == nil { | |||
There was a problem hiding this comment.
if this is a required item we should panic at the start of the node if it is not set. ideally here
feemarket/x/feemarket/keeper/keeper.go
Line 29 in f1f216e
There was a problem hiding this comment.
it does not seem like a required item. The current default TestDenomResolver is not meant for production and there are no other resolvers. Feemarket still functions as expected without it except for this small bug in the query_server
I have added a simple test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently the gas_prices endpoint is giving nil pointer error if resolver is not set due to it always calling
k.resolver.ExtraDenoms(ctx). This PR fixes it by returning only theparams.FeeDenomifk.resolver == nil