Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: last updated setting in x/marketmap keeper #799

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

aljo242
Copy link
Contributor

@aljo242 aljo242 commented Oct 16, 2024

Closes CON-1839

  • call SetLastUpdated for any Set or Remove calls in the keeper. (previously these calls were only done during the MsgServer which meant that hooks, or any keeper calls that are not part of a MsgServer call were not updating LastUpdated)
  • Add more testing around the LastUpdated field. Use randomized blockheights instead of constants
  • add checks to our E2E tests to ensure that the LastUpdated field is updated for all Tx we call.

Note, this fix is only for on-chain code, so a full upgrade would be needed. This is also state-breaking, so we will need to make a new v3.x release as any v1 or v2 version of the code will result in disparate states (last updated will be updated differently).

I will make another PR that will only updates the sidecar, which can be rolled out more quickly.

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 72.72727% with 3 lines in your changes missing coverage. Please review.

Project coverage is 56.97%. Comparing base (6e1fdb3) to head (2d55818).

Files with missing lines Patch % Lines
x/marketmap/keeper/keeper.go 62.50% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #799      +/-   ##
==========================================
- Coverage   56.98%   56.97%   -0.01%     
==========================================
  Files         213      213              
  Lines       14801    14807       +6     
==========================================
+ Hits         8434     8437       +3     
- Misses       5757     5759       +2     
- Partials      610      611       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant