Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dynamic metrics #785

Conversation

technicallyty
Copy link
Contributor

@technicallyty technicallyty commented Oct 2, 2024

adds a new metrics impl, dynamic metrics which is a thin wrapper for a Metrics impl. If the metrics impl is a noop impl, and we have telemetry enabled, dynamic metrics will kick off a routine that tries to contact the node. if the node is contacted successfully, we attempt to switch our metrics impl to OracleMetricsImpl.

@technicallyty technicallyty marked this pull request as draft October 2, 2024 16:53
Copy link

codecov bot commented Oct 2, 2024

Codecov Report

Attention: Patch coverage is 58.18182% with 23 lines in your changes missing coverage. Please review.

Project coverage is 57.17%. Comparing base (167f9ac) to head (4707f9c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
oracle/metrics/dynamic_metrics.go 59.25% 22 Missing ⚠️
cmd/connect/main.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #785      +/-   ##
==========================================
+ Coverage   56.55%   57.17%   +0.61%     
==========================================
  Files         212      213       +1     
  Lines       11846    11900      +54     
==========================================
+ Hits         6700     6804     +104     
+ Misses       4537     4486      -51     
- Partials      609      610       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@technicallyty technicallyty marked this pull request as ready for review October 2, 2024 17:22
oracle/metrics/dynamic_metrics.go Show resolved Hide resolved
@technicallyty technicallyty enabled auto-merge (squash) October 9, 2024 16:58
@technicallyty technicallyty merged commit da4b56c into main Oct 9, 2024
14 checks passed
@technicallyty technicallyty deleted the tyler/con-1797-connect-will-not-emit-telemetry-if-node-is-not-started branch October 9, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants