Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: connect sdk cosmwasm #779

Merged
merged 5 commits into from
Sep 30, 2024
Merged

docs: connect sdk cosmwasm #779

merged 5 commits into from
Sep 30, 2024

Conversation

technicallyty
Copy link
Contributor

@technicallyty technicallyty commented Sep 27, 2024

yerrrr

closes: CON-1770

Copy link

codecov bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.99%. Comparing base (2c36ea8) to head (ef0e784).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #779   +/-   ##
=======================================
  Coverage   56.99%   56.99%           
=======================================
  Files         210      210           
  Lines       11718    11718           
=======================================
  Hits         6679     6679           
  Misses       4431     4431           
  Partials      608      608           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@wesl-ee wesl-ee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L

use connect_sdk::bindings::query::ConnectQuery;
use connect_sdk::bindings::querier::ConnectQuerier;
use connect_sdk::bindings::marketmap::types::CurrencyPair;
use cosmwasm_std::{entry_point, Binary, Deps, DepsMut, Empty, Env, MessageInfo, Response, StdResult, to_json_binary, Int128, StdError};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unused imports: Binary, DepsMut, Empty, MessageInfo, Response, entry_point, and to_json_binary

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed em 🤙🏻

}

// Check price validity
let price_response = connect_querier.get_oracle_price(base, quote)?;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

error[E0061]: this method takes 1 argument but 2 arguments were supplied
--> contracts/x-oracle-passthrough/src/contract.rs:22:42
|
22 | let price_response = connect_querier.get_oracle_price(base, quote)?;

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, im using v0.1.0 for the example, likely an error from v0.2

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ill add that im using that version to the doc

@technicallyty technicallyty enabled auto-merge (squash) September 30, 2024 17:37
@technicallyty technicallyty merged commit 6833044 into main Sep 30, 2024
10 checks passed
@technicallyty technicallyty deleted the tyler/connect-sdk-docs branch September 30, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants