fix: Evict txs from mempool exceeding size limits #550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidterpay
added
backport/v1.x.x
davidterpay
requested review from
nivasan1,
aljo242 and
Eric-Warehime
as code owners
aljo242
approved these changes
Jun 25, 2024
aljo242
approved these changes
Jun 25, 2024
nivasan1
approved these changes
Jun 25, 2024
| @@ -49,7 +49,6 @@ func (h *ProposalHandler) PrepareLaneHandler() base.PrepareLaneHandler { | |||
| } | |||
|
|
|||
| cacheCtx, write := ctx.CacheContext() | |||
|
|
|||
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #550 +/- ##
==========================================
- Coverage 43.91% 43.59% -0.32%
==========================================
Files 63 63
Lines 2792 2812 +20
==========================================
Hits 1226 1226
- Misses 1439 1459 +20
Partials 127 127 ☔ View full report in Codecov by Sentry. |
There are tests for this, just added an additional condition check to ensure the tx was removed from the mempool |
|
|
|
not sure why codecov is saying no coverage when the test case hits that exact line of code. check cc: @Eric-Warehime |
|
|
mergify bot
pushed a commit
that referenced
this pull request
Jun 25, 2024
* init * nit test case (cherry picked from commit b8d9c22)
mergify bot
pushed a commit
that referenced
this pull request
Jun 25, 2024
* init * nit test case (cherry picked from commit b8d9c22)
davidterpay
added a commit
that referenced
this pull request
Jun 25, 2024
* init * nit test case (cherry picked from commit b8d9c22) Co-authored-by: David Terpay <[email protected]>
davidterpay
added a commit
that referenced
this pull request
Jun 25, 2024
* init * nit test case (cherry picked from commit b8d9c22) Co-authored-by: David Terpay <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.