Require username; NOT setting config implies not adding person to GitHub

skeptools · Dec 9, 2022 · 3aaefec · 3aaefec
1 parent 24082d3
commit 3aaefec
Show file tree

Hide file tree

Showing 10 changed files with 717 additions and 582 deletions.
diff --git a/.eslintrc.json b/.eslintrc.json
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
diff --git a/.github/workflows/pull-request-lint.yml b/.github/workflows/pull-request-lint.yml
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
diff --git a/.github/workflows/upgrade-main.yml b/.github/workflows/upgrade-main.yml
diff --git a/.projen/deps.json b/.projen/deps.json
diff --git a/.projen/tasks.json b/.projen/tasks.json
diff --git a/package.json b/package.json
diff --git a/src/person.ts b/src/person.ts
@@ -5,7 +5,7 @@ import { Organization } from './organization';
 
 export interface PersonProps extends BaseProps {
   readonly admin?: boolean;
-  readonly username?: string;
+  readonly username: string;
 }
 
 export class Person<
@@ -20,15 +20,13 @@ export class Person<
   ) {
     super(scope, namespace, config);
 
-    if (this._props.username) {
-      new github.membership.Membership(this, `${namespace}-membership`, {
-        username: this._props.username,
-        role: this._props.admin ? 'admin' : 'member',
-      });
-    }
+    new github.membership.Membership(this, `${namespace}-membership`, {
+      username: this._props.username,
+      role: this._props.admin ? 'admin' : 'member',
+    });
   }
 
-  get username(): string | undefined {
+  get username(): string {
     return this._props.username;
   }
 }