Fixed building path to files for Yii version >=2.0.39 with non-empty BaseUrl #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue was discussed here yiisoft/yii2#18414.
In version 2.0.39, there was a problem with projects with non-empty
BaseUrlandappendTimestampincluded. In this case, when the list of files (.css and .js) was compiled, the path to the file was built incorrectly when the file modification time was received.BaseUrlwas contained in both@webrootmask and relative file path. Those, it turned out something like thisG: /XAMPP7/htdocs/subdomain/site/web/subdomain/site/css/custom.cssinstead of the prescribedG: /XAMPP7/htdocs/subdomain/site/web/css/custom.css. There it was fixed by removingBaseUrlin the relative path.Here I found a similar problem: no compiled files were generated on projects with non-empty
BaseUrl. The script that bypassed the .css and .js lists could not get any of the files, since paths contained doubledBaseUrl.Fix #54