Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[22764] Catch a ride regression testing fixes #483

Merged

Conversation

MichaelReyes
Copy link
Collaborator

Pull Request (PR) Checklist

Thank you for your contribution! Please confirm that you've checked all the boxes below before submitting your PR. Use [x] to check a box, e.g., [x], and make sure there's no space around the brackets.

PR Context

Changes

Describe your changes in detail, highlighting the problem it solves or the feature it adds.

  • [TripGov5] update waupaca AndroidManifest.xml to add storage permissions
  • [TripGov5] update WaupacaApplication to initialize DistanceFormatter and inject UnitsRepository
  • [TripGov5] update AccountEditActivityViewModel.kt and add livedata to handle tripGoClientId and bind to activity_account_edit.xml
  • [TripGov5] update HomeViewModel to update how userData flow is collected when checking user bundle
  • [TripKitUI] update CustomBinding.kt to add tripGoClientId on the custom binder for profile image loading that requires additional auth headers to call
  • update DistanceFormatter to check and use units from UnitsRepository
  • update trip_result_list_item.xml to set again visibility for money cost
  • update TripResultViewModel to update visibility setting for money cost to only show if config hideTripMetrics is true

Checklist for Reviewers

Documentation and Code Quality

  • KDocs Documentation: Are all changes, new functionalities, and classes documented with KDocs?
  • Architectural Patterns: Is there consistent and proper use of architectural patterns (e.g., MVVM, MVP)?

Testing and Reliability

  • Unit Testing: Are there unit tests for all new functionalities and classes?
  • Emulator and Real Device Testing: Has the application been tested on both emulators and real devices to ensure compatibility?

Error Handling and Logging

  • Error Handling: Are errors and exceptions caught and handled gracefully, ensuring the app remains stable?
  • Logging: Is there proper logging in place for critical errors and information, aiding in debugging and monitoring?

Testing Procedure

If applicable, provide steps or commands for testing your changes. This can help reviewers and testers.

Work-in-Progress (WIP)

List any remaining work or areas that need additional focus. This section can be updated as the work progresses.

  • [ ]
  • [ ]

Remember to keep this template updated based on the feedback and evolving project standards.

- [TripGov5] update waupaca AndroidManifest.xml to add storage permissions
- [TripGov5] update WaupacaApplication to initialize DistanceFormatter and inject UnitsRepository
- [TripGov5] update AccountEditActivityViewModel.kt and add livedata to handle tripGoClientId and bind to activity_account_edit.xml
- [TripGov5] update HomeViewModel to update how userData flow is collected when checking user bundle
- [TripKitUI] update CustomBinding.kt to add tripGoClientId on the custom binder for profile image loading that requires additional auth headers to call
- update DistanceFormatter to check and use units from UnitsRepository
- update trip_result_list_item.xml to set again visibility for money cost
- update TripResultViewModel to update visibility setting for money cost to only show if config hideTripMetrics is true
Copy link

✅ Unit tests passed successfully!

Test results are available under the "Artifacts" section of this run in GitHub Actions.

Please ensure the code is reviewed before proceeding with the merge.

@MichaelReyes MichaelReyes merged commit b584682 into develop Nov 26, 2024
1 check passed
@MichaelReyes MichaelReyes deleted the bugfix/22764-catch-a-ride-regression-testing-fixes branch November 26, 2024 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants