Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[22512] show trip lines on map for route results #147

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

MichaelReyes
Copy link
Collaborator

Pull Request (PR) Checklist

Thank you for your contribution! Please confirm that you've checked all the boxes below before submitting your PR. Use [x] to check a box, e.g., [x], and make sure there's no space around the brackets.

PR Context

Changes

Describe your changes in detail, highlighting the problem it solves or the feature it adds.

  • [TripGov5] update HomeFragment to pass mapFragment instance to TripResultsFragment
  • [TripGov5] update TripResultsFragment to accept TripKitMapFragment instance and pass it to TripResultListFragment
  • update LineSegment to add tripUuid and convert to kotlin
  • update GetTravelledLineForTrip to pass include TripUuid on LineSegment
  • [TripKitUI] update RoutesComponent to add TripResultListMapContributor
  • [TripKitUI] update TripKitMapFragment to change how getting from and to marker bitmap is getting called
  • [TripKitUI] add TripKitMapUtils.kt for map specific utility functions
  • [TripKitUI] update TripLine to add execution for travelled lines only and with PolylineConfig
  • [TripKitUI] update TripResultListFragment to add and use TripResultListMapContributor and set it to TripKitMapFragment
  • [TripKitUI] add TripResultListMapContributor to handle showing of trip result routes on map when list loaded

Checklist for Reviewers

Documentation and Code Quality

  • KDocs Documentation: Are all changes, new functionalities, and classes documented with KDocs?
  • Architectural Patterns: Is there consistent and proper use of architectural patterns (e.g., MVVM, MVP)?

Testing and Reliability

  • Unit Testing: Are there unit tests for all new functionalities and classes?
  • Emulator and Real Device Testing: Has the application been tested on both emulators and real devices to ensure compatibility?

Error Handling and Logging

  • Error Handling: Are errors and exceptions caught and handled gracefully, ensuring the app remains stable?
  • Logging: Is there proper logging in place for critical errors and information, aiding in debugging and monitoring?

Testing Procedure

If applicable, provide steps or commands for testing your changes. This can help reviewers and testers.

Work-in-Progress (WIP)

List any remaining work or areas that need additional focus. This section can be updated as the work progresses.

  • [ ]
  • [ ]

Remember to keep this template updated based on the feedback and evolving project standards.

- [TripGov5] update HomeFragment to pass mapFragment instance to TripResultsFragment
- [TripGov5] update TripResultsFragment to accept TripKitMapFragment instance and pass it to TripResultListFragment
- update LineSegment to add tripUuid and convert to kotlin
- update GetTravelledLineForTrip to pass include TripUuid on LineSegment
- [TripKitUI] update RoutesComponent to add TripResultListMapContributor
- [TripKitUI] update TripKitMapFragment to change how getting from and to marker bitmap is getting called
- [TripKitUI] add TripKitMapUtils.kt for map specific utility functions
- [TripKitUI] update TripLine to add execution for travelled lines only and with PolylineConfig
- [TripKitUI] update TripResultListFragment to add and use TripResultListMapContributor and set it to TripKitMapFragment
- [TripKitUI] add TripResultListMapContributor to handle showing of trip result routes on map when list loaded
@MichaelReyes MichaelReyes changed the title [22512] [22512] show trip lines on map for route results Oct 23, 2024
@github-actions github-actions bot added the stale No updates, stale PR label Oct 29, 2024
@github-actions github-actions bot closed this Nov 1, 2024
@MichaelReyes MichaelReyes reopened this Nov 1, 2024
@github-actions github-actions bot removed the stale No updates, stale PR label Nov 2, 2024
- [TripKit] update GetTravelledLineForTrip to allow passing and using custom latlng tolerance to simplify the polylines
- [TripKitUI] update TripLine to pass custom tolerance for simplyfying polylines for trip list search result lines
- [TripKitUI] update TripResultListMapContributor to ensure proper thread when loading lines and add debounce to remove rendering of trip lines on map per result
@github-actions github-actions bot added the stale No updates, stale PR label Nov 11, 2024
@MichaelReyes MichaelReyes removed the stale No updates, stale PR label Nov 13, 2024
@github-actions github-actions bot added the stale No updates, stale PR label Nov 18, 2024
@MichaelReyes MichaelReyes removed the stale No updates, stale PR label Nov 19, 2024
@github-actions github-actions bot added the stale No updates, stale PR label Nov 25, 2024
@MichaelReyes MichaelReyes removed the stale No updates, stale PR label Nov 26, 2024
@github-actions github-actions bot added the stale No updates, stale PR label Dec 2, 2024
@MichaelReyes MichaelReyes removed the stale No updates, stale PR label Dec 2, 2024
@github-actions github-actions bot added the stale No updates, stale PR label Dec 8, 2024
@github-actions github-actions bot closed this Dec 11, 2024
@MichaelReyes MichaelReyes reopened this Dec 11, 2024
Copy link

❌ Unit tests failed!

@MichaelReyes, please review and fix the issues in the unit tests.

Test results are available under the "Artifacts" section of this run in GitHub Actions.

@MichaelReyes MichaelReyes removed the stale No updates, stale PR label Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants