Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/support for short color notation #194

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

bdlabs
Copy link

@bdlabs bdlabs commented Feb 18, 2023

Fixed render svg. Add support for short color notation.

Łukasz Koc added 3 commits February 18, 2023 09:52
@skanaar
Copy link
Owner

skanaar commented Feb 20, 2023

Very interesting to let uers register their own styles!
I will have to think a bit about this as this new public API will freeze the current implementation of layouters and visualizers.

@bdlabs
Copy link
Author

bdlabs commented Feb 20, 2023

OK, can you explain how? Maybe I missed something :)

@skanaar
Copy link
Owner

skanaar commented Feb 20, 2023

@bdlabs the sames changes appear in both this PR and in #193 . I got a bit confused.

What I mean is that right now the layouter and visualizer systems are private parts of nomnoml. So I am free to change them around whenever without breaking the public API.

If they are exposed they are "locked into place" and any changes to those systems would mean a breaking change.
So I would have to think carefully about that.

@skanaar
Copy link
Owner

skanaar commented Feb 20, 2023

Could you remove the stuff related to registerComponent from this PR so it only deals with the color notation? Thanks

@bdlabs
Copy link
Author

bdlabs commented Feb 21, 2023

My mistake, I did the merge wrong, didn't notice it :), I'll fix it today. Thanks.

@bdlabs
Copy link
Author

bdlabs commented Mar 2, 2023

Hi, what about this theme? :)

@skanaar
Copy link
Owner

skanaar commented Mar 2, 2023

Thank you for the reminder. I'm on a short vacation for the moment, will look at this next week.

@skanaar
Copy link
Owner

skanaar commented Mar 6, 2023

@bdlabs which SVG viewer are you using that gave you a buggy rendering?
Because I cannot reproduce the bug that this is supposed to solve.

@bdlabs
Copy link
Author

bdlabs commented Mar 18, 2023

@skanaar sorry, I don't remember. It was probably a render in phpstorm.

@skanaar
Copy link
Owner

skanaar commented Mar 18, 2023

Hmm, I will close this PR since I cannot reproduce the bug.
But I really appreciate the effort.

@skanaar skanaar closed this Mar 18, 2023
@skanaar skanaar reopened this Mar 19, 2023
@skanaar
Copy link
Owner

skanaar commented Mar 19, 2023

Reopening as I can reproduce it in JetBrains Fleet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants