-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/support for short color notation #194
base: master
Are you sure you want to change the base?
Fix/support for short color notation #194
Conversation
Labels were rendered as invisible.
Added fill-opacity attr.
Very interesting to let uers register their own styles! |
OK, can you explain how? Maybe I missed something :) |
@bdlabs the sames changes appear in both this PR and in #193 . I got a bit confused. What I mean is that right now the layouter and visualizer systems are private parts of nomnoml. So I am free to change them around whenever without breaking the public API. If they are exposed they are "locked into place" and any changes to those systems would mean a breaking change. |
Could you remove the stuff related to |
My mistake, I did the merge wrong, didn't notice it :), I'll fix it today. Thanks. |
Hi, what about this theme? :) |
Thank you for the reminder. I'm on a short vacation for the moment, will look at this next week. |
@bdlabs which SVG viewer are you using that gave you a buggy rendering? |
@skanaar sorry, I don't remember. It was probably a render in phpstorm. |
Hmm, I will close this PR since I cannot reproduce the bug. |
Reopening as I can reproduce it in JetBrains Fleet. |
Fixed render svg. Add support for short color notation.