Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Support for Converting Dataframe to FixedDataGrid #256

Merged

Conversation

Yushgoel
Copy link
Contributor

@Yushgoel Yushgoel commented Nov 4, 2020

Related to issue #254.

Before completely replacing FixedDataGrid, it is better to first check whether Dataframes are better with golearn.

This program allows you to convert a dataframe-go Dataframe object into a golearn FixedDataGrid instance.
Data preparation can be now be done in dataframes, and then converted to FixedDataGrid for using golearn's ML algos. After this, FixedDataGrid could be replaced altogether.

Copy link
Collaborator

@Sentimentron Sentimentron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Sentimentron Sentimentron merged commit 9ed5a13 into sjwhitworth:master Nov 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants