Add new MenuButtonImageUpload and insertImages util for handling/inserting user-uploaded images
#147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This better handles the text selection, utilizing Tiptap's internal `insertContentAt` logic to set the subsequent selection. It also inserts all nodes in one go, simplifying how we perform insertion. This also changes the API/fields of the image upload and insert functionality so that it directly uses all image node attributes.
sjdemartini
force-pushed
the
image-upload-button
branch
from
894b756 to
1e540d9
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses one of the requests from #136 (likely the more common one, vs the external URL use-case).
Also add paste and drop handlers to the mui-tiptap demo example, so users can copy-paste and drag-and-drop images directly into the editor content.
Note that for the purposes of this demo, there is no server where images are uploaded, so they're simply temporary local object URLs which wouldn't persist in a "real" production context. Users of
MenuButtonImageUploadwill need to provide their ownonUploadFilesprop in order to take the imageFiles, upload them, and return URLs at which the images can be served/viewed.Demo