Add gitignore and move setup into pyproject.toml #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dependencies that are currently installed through the install_dependencies.sh script, can also be installed via the pyproject.toml file. The only dependency I couldn't figure out how to install properly is mmcv, since I couldn't find a way to specify the install index in the pyproject.toml file. Additionally, mmcv seems to miss torch as a build dependency, so we have to explicitly install that before installing mmcv...
I tested this setup and the new install instructions in a fresh conda environment. The demo scripts work fine.
The gitignore is from here