Add Escaping for Identifiers and Literals in Migrations #538
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #537
Adds escaping for identifiers (table names, users, etc) using
pq.QuoteIdentifier
, and for literals usingpq.QuoteLiteral
. This allows usernames with characters like-
and@
, passwords with'
, and resolves a SQL injection vulnerability.Updates
github.com/lib/pq
to the latest version. It needed to be upgraded to at least v1.2.0, which added theQuoteLiteral
function.Verification done thus far:
-
and@
in the username)