Skip to content

Commit

Permalink
Angular 8 support. Resolves #83.
Browse files Browse the repository at this point in the history
  • Loading branch information
joeldenning committed Jul 5, 2019
1 parent eb17d35 commit 52f55ce
Show file tree
Hide file tree
Showing 7 changed files with 286 additions and 20 deletions.
166 changes: 162 additions & 4 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 4 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,14 +28,17 @@
},
"homepage": "https://github.com/CanopyTax/single-spa-angular#readme",
"peerDependencies": {
"@angular-builders/custom-webpack": "^8",
"@angular-devkit/architect": ">= 0.10.0",
"@angular-devkit/build-angular": ">= 0.10.0",
"@angular-devkit/core": ">= 0.10.0",
"@angular/compiler": ">=2",
"@angular/compiler-cli": ">=2",
"@angular/core": ">=2",
"rxjs": ">= 6.0.0",
"webpack": ">=4.6.0"
"semver": "^6.2.0",
"webpack": ">=4.6.0",
"webpack-merge": "^4.2.1"
},
"devDependencies": {
"@angular-devkit/architect": "^0.13.6",
Expand All @@ -61,7 +64,6 @@
"webpack": "^4.29.6"
},
"dependencies": {
"webpack-merge": "^4.2.1",
"single-spa": ">= 4.0.0"
}
}
8 changes: 8 additions & 0 deletions src/schematics/ng-add/_files/extra-webpack.config.js.template
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
const singleSpaAngularWebpack = require('single-spa-angular/lib/webpack').default

module.exports = (angularWebpackConfig, options) => {
const singleSpaWebpackConfig = singleSpaAngularWebpack(angularWebpackConfig, options)

// Feel free to modify this webpack config however you'd like to
return singleSpaWebpackConfig
}
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import 'core-js/es7/reflect';
<% if (!atLeastAngular8) { %>import 'core-js/es7/reflect';<% } %>
<% if (routing) { %>import { enableProdMode, NgZone } from '@angular/core';<% } %>
<% if (!routing) { %>import { enableProdMode, NgZone } from '@angular/core';<% } %>
import { platformBrowserDynamic } from '@angular/platform-browser-dynamic';<% if (routing) { %>
Expand Down
Loading

0 comments on commit 52f55ce

Please sign in to comment.