-
Notifications
You must be signed in to change notification settings - Fork 845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: color picker dialog hex field value not setting correctly #2415
Conversation
Thank you for the contribution, your branch is outdated, could you rebase to fix the CI failure? Also, a CHANGELOG.md change is needed to document your fix. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need more details to document the bug fix.
I have added a test (505ed70) that is failing now. With the bug fix of this PR, the test will pass. Thank you for your contribution. |
Before and after videos
CurrentBehavior.movBugFix.movBug details: The hex color field initial value in the color picker dialog is not set correctly when selecting a text (that has a color) in the editor and pressing the color button in the toolbar (to open the dialog). |
Description
Currently, when you pick a color from the toolbar(either font or background color), the hex field in the color picker value has always the same value. This fix will make the field display the current value.
Related Issues
Type of Change