Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: color picker dialog hex field value not setting correctly #2415

Merged
merged 5 commits into from
Dec 19, 2024

Conversation

geronimol
Copy link
Contributor

@geronimol geronimol commented Dec 12, 2024

Description

Currently, when you pick a color from the toolbar(either font or background color), the hex field in the color picker value has always the same value. This fix will make the field display the current value.

Related Issues

Type of Change

  • Feature: New functionality without breaking existing features.
  • 🛠️ Bug fix: Resolves an issue without altering current behavior.
  • 🧹 Refactor: Code reorganization, no behavior change.
  • Breaking: Alters existing functionality and requires updates.
  • 🧪 Tests: New or modified tests
  • 📝 Documentation: Updates or additions to documentation.
  • 🗑️ Chore: Routine tasks, or maintenance.
  • Build configuration change: Build/configuration changes.

@EchoEllet
Copy link
Collaborator

Thank you for the contribution, your branch is outdated, could you rebase to fix the CI failure? Also, a CHANGELOG.md change is needed to document your fix.

Copy link
Collaborator

@EchoEllet EchoEllet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need more details to document the bug fix.

EchoEllet added a commit that referenced this pull request Dec 19, 2024
@EchoEllet
Copy link
Collaborator

I have added a test (505ed70) that is failing now. With the bug fix of this PR, the test will pass. Thank you for your contribution.

@EchoEllet
Copy link
Collaborator

EchoEllet commented Dec 19, 2024

Before and after videos

CurrentBehavior.mov
BugFix.mov

Bug details: The hex color field initial value in the color picker dialog is not set correctly when selecting a text (that has a color) in the editor and pressing the color button in the toolbar (to open the dialog).

@EchoEllet EchoEllet merged commit 9eacc2a into singerdmx:master Dec 19, 2024
3 checks passed
@EchoEllet EchoEllet changed the title fix: Color picker hex field fix: color picker dialog hex field value not setting correctly Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants