-
Notifications
You must be signed in to change notification settings - Fork 845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
revert!: magnifier #2413
Draft
EchoEllet
wants to merge
8
commits into
master
Choose a base branch
from
revert/magnifier-feat
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
revert!: magnifier #2413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is in editor_keyboard_shortcut_actions_manager.dart and added back due to git revert
This PR is not ready yet for merge. Should double-check the changes, and manually compare the changes. Also, need to manually test the changes for possible regressions, test it before the magnifier, after it was added, and after reverting it (with this branch). Before magnifier$ git clone --branch v9.5.23 --depth 1 [email protected]:singerdmx/flutter-quill.git flutter-quill-before-magnifier
$ (cd flutter-quill-before-magnifier/example && flutter run) After the magnifier with all changes and fixes$ git clone --branch v11.0.0-dev.14 --depth 1 [email protected]:singerdmx/flutter-quill.git flutter-quill-latest-with-magnifier
$ (cd flutter-quill-latest-with-magnifier/example && flutter run) After reverting the magnifier$ git clone --branch revert/magnifier-feat --depth 1 [email protected]:singerdmx/flutter-quill.git flutter-quill-without-magnifier
$ (cd flutter-quill-without-magnifier/example && flutter run) Videos
No issues, and seem to work as before: AndroidApi35Test.moviOS16Test.movA buggy behavior reproduced after the revert; need to test it before and after the magnifier too: AndroidBuggyBehavior.mov |
Open
1 task
EchoEllet
added
the
breaking change
This change introduces an incompatibility that requires adjustments in dependent code or packages, a
label
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking change
This change introduces an incompatibility that requires adjustments in dependent code or packages, a
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove the magnifier due to buggy behavior with many regressions.
See #2406 for a list of issues, reasons, and details.
This reverts the two related PRs using:
And then removed anything related to the magnifier that was made in related PRs manually.
To try this branch:
Related Issues
Type of Change