-
Notifications
You must be signed in to change notification settings - Fork 845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix!: remove super_clipboard from flutter_quill_extensions and move it to quill_super_clipboard #2322
Conversation
… to quill_super_clipboard
I'm uncertain if we should not merge this, if we keep Updating the |
Since this is a breaking change and it's necessary, I will have to publish it as a new major version |
* fix!: remove super_clipboard from flutter_quill_extensions and move it to quill_super_clipboard (#2322) * chore!: remove the controller from the configuration class, remove the quill toolbar and editor provider widgets, and other minor breaking changes * chore!: remove SimpleSpellCheckerService from flutter_quill_extensions * chore!: remove experimental support for spell checking, remove the deprecated support for YouTube in flutter_quill_extensions, and other minor breaking changes * chore(deps): remove equatable * chore!: remove quill shared configuration and toolbar shared configuration * chore!: remove QuillController.setContents() * chore!: remove QuillController.editorFocusNode * chore: remove outdated comments * chore: always call setState() in _markNeedsBuild() in QuillRawEditorState even if dirty is already true (revert to old behavior) * chore: extract code from _requestKeyboard() and add docs comment for _requireEditorCurrentState * chore!: remove classes related to editor element options, minor docs updates in editor config, rename isOnTapOutsideEnabled to onTapOutsideEnabled * chore!: rename 'Configurations' to 'Config' * chore!: refactor build method of the embed block interface * chore!: remove the experimental table support from flutter_quill_extensions * chore!: remove old deprecated properties * chore!: rename rawItemsMap to items for font family and font size options * chore!: remove deprecated formula embed support from flutter_quill_extensions * chore!: remove deprecated class SuperClipboardService, rename the directory models to config in flutter_quill_extensions * chore: add commnet in imageProviderBuilder code docs comment in flutter_quill_extensions * docs: fix typos in migration * docs(readme): replace deprecated flutter_quill_internal.dart with internal.dart * docs(readme): improve README * docs(readme): add the GitHub flutter_quill code snippet back * docs: add more details to the migration guide * fix(ios): use the localized strings for 'open', 'copy', and 'remove' * chore: rename the file quill_controller_configurations.dart to quill_controller_config.dart * chore!: avoid storing quill editor config inside Document * chore: restore search within embed objects feature (revert removal of editor config inside the QuillController) * chore: add @experimental to some APIs * docs: add emojis to the migration guide, add the migration guide link in README.md * chore: removes quill controller web files, updates QuillControllerConfig.onClipboardPaste to allow overriding the default paste handling * docs: fix typos in the migration guide * chore: minor change in the migration guide * docs: update link of QuillControllerConfig.onClipboardPaste in the migration guide * chore: fix dart analysis issues * chore: mark QuillEditorConfig.customLeadingBlockBuilder as experimental * chore!: avoid exporting OptionalSize * chore: rename _restoreToolbar to _restoreToolbarAfterMagnifier in text_selection.dart * chore: annotate QuillEditorConfig.magnifierConfiguration as experimental * chore: minor cleanup to magnifier feature * chore: export missing class, fix #2333 * chore: fix dart analysis * chore(release): temp changes to publish 11.0.0 (will revert changes of this commit) * chore: add temp dependency_overrides to fix CI failure * chore: temp changes to publish 11.0.0-dev.1 * ci(publish): temp change to fix CI failure * chore: restore previous publish workflow (revert), update min version of flutter_quill in test and extensions packages, remove pubspec_overrides.yaml * chore: revert CHANGELOG.md and publish.yml changes * chore: revert a change in #2026 (see comment https://github.com/singerdmx/flutter-quill/pull/2026/files#r1679744497) * chore: revert change of reverting the removal of _handles check introduced by #2026 * docs(migration): clarify the removal of the QuillToolbar widget * docs(migration): improve removal of the QuillToolbar section * docs: add the custom toolbar page link in: removal of the QuillToolbar * docs: add important info at the top of the migration guide * feat(toolbar): add the base button options feature back, supports flutter_quill_extensions's buttons too. * chore: fix analysis warnings * docs: add more details in the migration guide in the breaking behavior with code snippets * chore: minor change to the 'Breaking behavior' section * chore(deps): improve dependencies constraints for compatibility - Fix #2341 - Fix #2347 * docs(migration): explain that QuillToolbar is not a visual widget like QuillSimpleToolbar * docs: minor changes to README.md and migration guide * feat: clipboard paste callbacks, partial fix to #2350 * docs: update outdated link in the migration guide * chore: rename deltaToPaste() to getDeltaToPaste() * docs: improve CHANGELOG.md format and quality, fixing #2211 * ci: pass the GitHub token to an action * docs: fix format of CHANGELOG.md * ci: use cider for CHANGELOG.md format validation * ci: add a TODO to improve CHANGELOG.md validation * chore: remove flutter_quill_extensions from publishing * chore: publish flutter_quill_extensions and add 'insertVideo' in quill_en.arb * chore(release): prepare to publish 11.0.0-dev.3 * ci: increase _expectedTranslationKeysLength due to 'insertVideo' * ci: use a GitHub action to update the release notes * chore(release): publish flutter_quill_extensions 11.0.0-dev.3 * chore(release): prepare to publish 11.0.0-dev.4 * ci: remove the release notes file creation * chore(example): delete the current example to recreate * chore: recreate the example (fix #2249), minor changes to flutter_quill_extensions * docs(readme): update the screenshots of the example app * docs(readme): update sample page link, remove 'breaking changes' from table of contents only * feat: add the option to disable rich text paste feature, partial fix to #2350 * chore(release): prepare to publish 11.0.0-dev.5 * chore: regenerate translations to reflect #2358 * chore: ignore deprecations * docs: fix a minor issue in the Contributing guide * chore(example): add file read access for macOS * feat(l10n): localize "insert video" for Khmer language Source: #2358 (comment) * chore: simplify PR template * docs: update development notes * docs(readme): use images from GitHub repo instead of relative path to load on pub.dev
Description
Moving
super_clipboard
dependency from flutter_quill_extensions to quill_super_clipboard.Minor breaking change
Unfortunately, this is a breaking change, while it doesn't require changes in Dart code, it requires removing the following from
AndroidManifest.xml
if was configured to launch the app:The new default implementation (#2230) uses quill_native_bridge which supports all the features that are used by
flutter_quill
and was made to avoid introducing a breaking change (changing the previous behavior), though I have missed that the required provider inAndroidManifest.xml
is in super_native_extensions, removingsuper_clipboard
also removessuper_native_extensions
and that plugin has the classcom.superlist.super_native_extensions.DataProvider
which doesn't exist anymore, you will be unable to run the app.Migration
Remove the following if used:
A. Using the new default implementation
The android configuration of
super_clipboard
is no longer required.The following snippet should be removed otherwise you will be unable to launch the app:
The error will be encountered when not removing this
See the
quill_native_bridge
platform configuration (optional for copying images on Android).Other Optional changes
minSdkVersion
:android { defaultConfig { minSdk = flutter.minSdkVersion } }
ndkVersion
:android { ndkVersion = flutter.ndkVersion }
B. Continue using the
super_clipboard
implementationUse the new default implementation or if you want to continue using
super_clipboard
, use the package quill_super_clipboard (support might be discontinued in future releases).Related Issues
Type of Change