Default web clipboard status to pasteable and don't make clipboard status checks on web. (fixes #1567) #1721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Example builds on iPhone / Web didn't change anything w/example or Linux |
|
@mtallenca Please resolve conflict |
mtallenca
force-pushed
the
fix_safari_clipboard_bug
branch
from
1052bfa to
5d9dc10
Compare
|
This PR change nothing? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With Safari 17.2.1 on Desktop and iOS 17 Safari - performing Clipboard status checks causes a "Paste" menu to be displayed and stops user input. The status checks were initialized by ClipboardStatusNotifier when a default value of "unknown" was used in it's constructor as well as each time the editor content changed. This PR gives the web a default value of ClipboardStatus.pasteable and doesn't force update calls when content change on web.
Related Issues
Suggestions
Cut/Copy/Paste with keyboard shortcuts work on web, but right click menu items cut/copy/paste do not work correctly. This PR does not address this existing issue.
Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?