Major update 6 #1461
Merged
Major update 6 #1461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
flutter_quill_extensions will fail again, we probably need to publish the package to pub.dev and then update things from flutter_quill_extensions, also we should publish the flutter_quill_extensions updates to pub.dev |
|
Another option is that you publish the package instead |
Are we talking about flutter_quill_extensions?? because you told me @Jon-Salmon has access to the publishing |
|
Yes I mean if you don't want to be blocked on that. Create a new package |
Do you mean fork the repository of flutter_quill_extensions?? |
|
Oh pub.dev check url uniqueness? I see. Probably have to work around it |
|
Yes |
|
Sure |
|
Can't run the example - it shows failed assertion. |
Please clean the project and run it again and make sure to fetch the latest changes and rebase or merge
Can't encounter the issue you are facing, consider giving me more details so I can fix it |
|
Hm, it also works for me on Android emulator. |
if it is related to the Linux binary application building. then I can't fix it right now since this library is not supported for Linux yet as it uses plugins that don't support Linux yet. I will look into that soon but it would be helpful to share more details |
|
I think the idea of example is that it loads 'assets/sample_data.json' for mobile and 'assets/sample_data_nomedia.json' for desktop, and therefore works for desktop OS too, just without dealing with images, videos, etc. The traceback is as follows: |
|
Please also take a look at #1288, cause it seems to be connected with images which you're also working on. |
Sure, I will checkout tomorrow. But can you upload some images or short video?? |
|
Thank you for the report As soon we finish the refactoring and other issues we will work on this one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More changes...