Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major update 5 #1456

Merged
merged 2 commits into from
Oct 23, 2023
Merged

Major update 5 #1456

merged 2 commits into from
Oct 23, 2023

Conversation

EchoEllet
Copy link
Collaborator

  1. Moved all the buttons configurations to the QuillToolbarConfigurations in the buttonsOptions, at least all of the ones that are used in QuillToolbar.basic()

  2. add the ability to customize the Search dialog pressed callback and also a child builder

Example

search: QuillToolbarSearchButtonOptions(
                tooltip: 'Hello',
                customOnPressedCallback: (controler) async {
                  showDialog(
                    context: context,
                    builder: (context) {
                      return QuillToolbarSearchDialog(
                        controller: controler,
                        childBuilder: (extraOptions) {
                          return AlertDialog(
                            content: TextField(
                              controller: extraOptions.textEditingController,
                            ),
                            actions: [
                              ElevatedButton(
                                onPressed: extraOptions.onFindTextPressed,
                                child: const Text("Searh"),
                              ),
                            ],
                          );
                        },
                      );
                    },
                  );
                },
              )

this should address #1440 the search UI issue

  1. Update flutter_quill_extensions to use the latest version of flutter_quill
  2. Some little unnoticeable performance improvements

Our next step refactor the rest of the unused buttons with just a few left, we should review all the changes from scratch and cleanup the code, fix things, do some adjustments and improvements as well as little features
then we will work on the toolbar configurations

but before going further I think we need to discuss some stuff about the changes in the discussions or somewhere else if you guys have a channel in Discord, telegram, or any chat app we can talk there, we also can do this in the discussions. Personally prefer more live chat app

@EchoEllet EchoEllet requested a review from singerdmx October 23, 2023 15:40
@singerdmx singerdmx merged commit 6cf9cd0 into singerdmx:master Oct 23, 2023
1 check passed
@EchoEllet EchoEllet changed the title Major update 6 Major update 5 Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants