Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major update step 4 #1454

Merged
merged 1 commit into from
Oct 22, 2023
Merged

Major update step 4 #1454

merged 1 commit into from
Oct 22, 2023

Conversation

EchoEllet
Copy link
Collaborator

Managed to refactor most of the button configurations and move them to the new QuillProvider which will allow to customize every single button widget (except the Select Alignment buttons but we will work on that) and there are just three buttons left to refactor, the headline, search and insert link buttons

then we will refactor the QuillToolbar and then the editor which is the hardest part but we will manage

@singerdmx Feel free to merge this pull request but it's not necessary to publish yet, I will start on the others tomorrow so it's really not necessary to release two versions in a short time

and it's doesn't have much bug fixes, just improvements

I also added experimental animation support and it's disabled by default
and I just added it to the checkbox list for now it has one single issue that is not related to the animations or the changes we made but I will mention that later, I also marked it as experimental so developers know that when enabling it

which is the list of the checkboxes that will rebuild most of the items when there is a change
and it will cause the animation to replay for all the other items when there is a new change

a simple solution would be using the official animated lazy list from the Flutter framework but we will work on that later

let's fix more issues and add further improvements then we will release all in one go instead of too many releases
it won't take long just a few days

I also updated the and added quick instructions to use the library directly using git instead of the pub.dev so no need to publish the release, developers will be able to test this without publishing this release

@EchoEllet EchoEllet requested a review from singerdmx October 22, 2023 23:18
@EchoEllet
Copy link
Collaborator Author

EchoEllet commented Oct 22, 2023

image
I don't have any analysis errors on my local machine
but to fix those we probably need to update flutter_quill_extensions in pub.dev first

@singerdmx
Copy link
Owner

There is CI failure

@singerdmx singerdmx merged commit ee19189 into singerdmx:master Oct 22, 2023
1 check failed
@singerdmx
Copy link
Owner

@freshtechtips
Do you want to publish flutter_quill 7.8.0 to https://pub.dev (y/N)? y
Uploading... (2.0s)
Invalid topics value (rich text editor): must consist of lowercase alphanumerical characters or dash (but no double dash), starting with a-z and ending with a-z or 0-9.

@EchoEllet
Copy link
Collaborator Author

@freshtechtips
Do you want to publish flutter_quill 7.8.0 to https://pub.dev (y/N)? y
Uploading... (2.0s)
Invalid topics value (rich text editor): must consist of lowercase alphanumerical characters or dash (but no double dash), starting with a-z and ending with a-z or 0-9.

I will remove it tomorrow "rich text editor" topic item in pubspec.yanl

Because I'm in the middle of a dream right now

It's stringe that --dry-run success

@singerdmx
Copy link
Owner

already fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants