Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major update 2 #1446

Merged
merged 4 commits into from
Oct 21, 2023
Merged

Major update 2 #1446

merged 4 commits into from
Oct 21, 2023

Conversation

EchoEllet
Copy link
Collaborator

@EchoEllet EchoEllet commented Oct 21, 2023

Pull Request

Description

Step 2 of the major update

Improvements

  • Fix performance issues in the History button
  • More customizations
  • Code organization
  • Almost complete the BaseButton options
  • Other improvements, we will start on step 3 as soon this gets approved

Additional notes

I suggest not publishing this release yet, instead wait while I send the other pull requests which can be up to 15 and 5 as a minimum, and then release version 8.0.0

but that is up to you if you want to even though I prefer to release something more stable and complete in one go

Why did I send this pull request now??

Again to avoid conflicts since I have renamed a lot of things and organized the buttons widgets into one folder,
it will require more time to fix the conflicts because while I make the other changes it can take quite some time

and it will be harder to review and test

To save some time I will not mention this in step 3 of the major update 8.0.0
and probably won't mention many details because we definitely would rather spend that time on the updates, fixes, and other improvements for now

after the major update 8.0.0, the flutter_quill_extensions will probably need to be updated and we will work on that next in order to work with the latest version

Checklist

  • I have added/updated relevant documentation
  • I have tested these changes locally.
  • I have followed the code style and guidelines.
  • I have updated CHANGELOG.md with my changes in the next section
  • I have run `dart format .`` on the project
  • I have run dart fix --apply on the project
  • I have run flutter test and flutter analyze and it passed successfully

@EchoEllet EchoEllet requested a review from singerdmx October 21, 2023 16:45
@singerdmx singerdmx merged commit 3a82930 into singerdmx:master Oct 21, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants