Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New improvemenets and documentation #1443

Merged
merged 13 commits into from
Oct 20, 2023

Conversation

EchoEllet
Copy link
Collaborator

Pull Request

Description

I have updated the documentation
The readme and add a pull request template
Some simple code format
Update deprecated members

Issues

  • I was trying to fix the issue #1440 but I decided to not change too much to not introduce bugs or unexpected behavior

Improvements

  • Improve code readability
  • Update documentation

Additional notes

I was planning on adding more changes and more issues and bug fixes and more features but since we will make a major change I decided to focus on the major changes instead
and most of the changes

Checklist

  • I have added/updated relevant documentation
  • I have tested these changes locally.
  • I have followed the code style and guidelines.
  • I have updated CHANGELOG.md with my changes in the next section
  • I have run "dart format ." on the project
  • I have run flutter test and flutter analyze and it passed successfully

CHANGELOG.md Show resolved Hide resolved
@singerdmx
Copy link
Owner

What do I do about 7.4.15?

@singerdmx
Copy link
Owner

Can you just do your next thing next time

@singerdmx
Copy link
Owner

Make it 7.4.16 and add changelog for 15 and 16

@EchoEllet
Copy link
Collaborator Author

What do I do about 7.4.15?

Easy, just add version 7.4.15 yourself and cut all the items from the next section to make it empty again

@singerdmx
Copy link
Owner

Next time. Not this time

@EchoEllet
Copy link
Collaborator Author

Can you just do your next thing next time

What do you mean by next thing?? are we talking about the major change or the changelog??

@singerdmx
Copy link
Owner

I am confused. I don't know anymore

@singerdmx
Copy link
Owner

You are just making me confused

@singerdmx
Copy link
Owner

Just make it 7.4.16 please

@EchoEllet
Copy link
Collaborator Author

I am confused. I don't know anymore

Me too, let me make this clear

when you receive a pull request, we want the contributors to mention the changes in the next section in the changelog.md
when the publisher decides to publish a new version he should take all the changes from the next section and add them to the next version he wants to add he will decide this by himself and not from the contributors and it will be based on those changes

if you don't like this approach then we will follow yours.

@singerdmx
Copy link
Owner

I made it clear I DO NOT want that

@EchoEllet
Copy link
Collaborator Author

I made it clear I DO NOT want that

If you don't want that then you could have said it
and now I have done the changes to what you want

@EchoEllet EchoEllet requested a review from singerdmx October 20, 2023 14:38
Copy link
Owner

@singerdmx singerdmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is missing 7.4.14

@EchoEllet EchoEllet requested a review from singerdmx October 20, 2023 14:40
@singerdmx singerdmx merged commit 7c5a12b into singerdmx:master Oct 20, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants