Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes to default editor and toolbar values #1438

Merged
merged 3 commits into from
Oct 19, 2023
Merged

Changes to default editor and toolbar values #1438

merged 3 commits into from
Oct 19, 2023

Conversation

milindgoel15
Copy link
Contributor

  • Added an option to define a custom text selection colour in the editor
  • Added an option to set up box decoration for the toolbar.

@milindgoel15 milindgoel15 mentioned this pull request Oct 19, 2023
Closed
@milindgoel15
Copy link
Contributor Author

the color selection is not needed because I already did it and we will not have a conflict because I did it by overriding the textSelectionThemeData and not just the cursor color

In such case, the toolbar commit can be cherry-picked.

@singerdmx
Copy link
Owner

Let me know if this PR should be closed

@milindgoel15
Copy link
Contributor Author

You can cherry pick the commit related to toolbar.

@singerdmx singerdmx mentioned this pull request Oct 19, 2023
Merged
@milindgoel15
Revert "added a textSelectionColor property to fix [Feature Request] …
6f19e0f 
…More UI customisation options #1431"

This reverts commit 7cfa8af.
@milindgoel15
Copy link
Contributor Author

Reverted the commit related to text selection. PR can be merged now

@singerdmx singerdmx merged commit 43d2043 into singerdmx:master Oct 19, 2023
1 check passed
@singerdmx
Copy link
Owner

I will publish but @Jon-Salmon owns the package of extension

@EchoEllet
Copy link
Collaborator

I will publish but @Jon-Salmon owns the package of extension

Only flutter_quill needed to be updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@milindgoel15 @singerdmx @EchoEllet