Skip to content

Commit

Permalink
Remove old property
Browse files Browse the repository at this point in the history
  • Loading branch information
EchoEllet committed Oct 26, 2023
1 parent 2a1b7f5 commit 56213ff
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 6 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
- Remove property `enableUnfocusOnTapOutside` in QuillEditor Configurations and add `isOnTapOutsideEnabled` instead
- Add a new callback which is called `onTapOutside` in the `QuillEditorConfigurations` which allow you to do something when tap outside of the edtior
- Fix a bug which cause the web platform to not unfocus the editor when tap outside of it (the default logic) to override this pleae pass a value to the callback ``onTapOutside``
- Remove the old proerty of `iconTheme`, instead pass `iconTheme` in the button options, you will find `base` property there, inside it there is `iconTheme`

## [8.0.0]
- If you have mirgrated recently, don't get scared from this update, it just add a documentation, mirgration guide and mark the version as more stable release, since we did break a lot of breaking changes (at least that what most developers says) we should have change the major version but when we were in the development of this new version, our time was very tight and now we are fixing the version number
Expand Down
6 changes: 3 additions & 3 deletions lib/src/models/config/toolbar/configurations.dart
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ class QuillToolbarConfigurations extends Equatable {
this.linkDialogAction,

///The theme to use for the icons in the toolbar, uses type [QuillIconTheme]
this.iconTheme,
// this.iconTheme,
this.dialogTheme,
this.axis = Axis.horizontal,
this.color,
Expand Down Expand Up @@ -209,8 +209,8 @@ class QuillToolbarConfigurations extends Equatable {
/// Toolbar items to display for controls of embed blocks
final List<EmbedButtonBuilder>? embedButtons;

///The theme to use for the icons in the toolbar, uses type [QuillIconTheme]
final QuillIconTheme? iconTheme;
// ///The theme to use for the icons in the toolbar, uses type [QuillIconTheme]
// final QuillIconTheme? iconTheme;

///The theme to use for the theming of the [LinkDialog()],
///shown when embedding an image, for example
Expand Down
9 changes: 6 additions & 3 deletions lib/src/widgets/toolbar/toolbar.dart
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,10 @@ class QuillToolbar extends StatelessWidget {
),
if (theEmbedButtons != null)
for (final builder in theEmbedButtons)
builder(controller, globalIconSize, configurations.iconTheme,
builder(
controller,
globalIconSize,
context.requireQuillToolbarBaseButtonOptions.iconTheme,
configurations.dialogTheme),
if (configurations.showDividers &&
isButtonGroupShown[0] &&
Expand Down Expand Up @@ -350,8 +353,8 @@ class QuillToolbar extends StatelessWidget {
context.quillToolbarBaseButtonOptions?.iconData,
iconColor: customButton.iconColor,
iconSize: customButton.iconSize ?? globalIconSize,
iconTheme: configurations.iconTheme ??
context.quillToolbarBaseButtonOptions?.iconTheme,
iconTheme:
context.requireQuillToolbarBaseButtonOptions.iconTheme,
afterButtonPressed: customButton.afterButtonPressed ??
context
.quillToolbarBaseButtonOptions?.afterButtonPressed,
Expand Down

0 comments on commit 56213ff

Please sign in to comment.