Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for boolean value for color option #244

Merged

Conversation

Mallikarjun-0
Copy link
Contributor

@Mallikarjun-0 Mallikarjun-0 commented Jan 28, 2025

color property of class Ora can be a boolean false for the default color of spinner, but the type hint only mentions Color whereas it should be Color | boolean.

@sindresorhus
Copy link
Owner

You have not updated all the places that needs updating.

@Mallikarjun-0
Copy link
Contributor Author

@sindresorhus I changed the type in the options as well, is there any other place where it needs to be changed?

@sindresorhus
Copy link
Owner

I changed the type in the options as well, is there any other place where it needs to be changed?

I think if you just checked instead of asking you would quickly see that you also need to update the readme.

@Mallikarjun-0
Copy link
Contributor Author

@sindresorhus updated the readme with the required type changes.

@sindresorhus sindresorhus changed the title Ora.color can have a boolean value false for default spinner color. Add support for boolean value for color option Feb 2, 2025
@sindresorhus sindresorhus merged commit fe951e5 into sindresorhus:main Feb 2, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants