Additional matching URLs for the notifications page #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notlmn
requested changes
Sep 14, 2024
source/lib/tabs-service.js
Outdated
| if (url.endsWith('/notifications')) { | ||
| matchingUrls.push(url + '?query=is%3Aunread'); | ||
| if (new URL(url).pathname.endsWith('/notifications')) { | ||
| matchingUrls.push(url + '?query=*'); |
There was a problem hiding this comment.
The canonical link to the notifications page is https://github.com/notifications, not https://github.com/notifications?query= which you could be using here.
The code looks for any tabs that have /notifications or /notifications?query=is%3Aunread.
The actual fix here should be adding another matching URL to look for.
Suggested change
| matchingUrls.push(url + '?query=*'); | |
| matchingUrls.push(url + '?query='); | |
| matchingUrls.push(url + '?query=is%3Aunread'); |
This also does not require you to use the new URL(url).pathname, the param being passed to this function would always be a constant.
There was a problem hiding this comment.
applied in 1e30721 (#299).
Co-authored-by: Laxman <[email protected]>
notlmn
approved these changes
Sep 15, 2024
notlmn
changed the title
/notifications
|
Merged this, but beware that publishing to AMO is paused due to lack of full support of MV3. Further context in #298. |
scarf005
deleted the
fix/296/feature-request-more-lax-condition-for-`reuse-notification-tabs-when-possible`
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #296