Type casting bug in STM32HWEncoder fixed #52
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Found this bug while trying to get this code to work:
This is the related part of my
platformio.ini
config:In this case, PA0 is 192 and PA1 is 193. Currently, when you pass pins to the
STM32HWEncoder
constructor, they're trimmed down to theint8_t
, which is incorrect. In my case 192 and 193 do not actually fit into theint8_t
, and trimming then leads to incorrect operation of thedigitalPinToPinName
function. So I just changedint8_t
toint